-
Notifications
You must be signed in to change notification settings - Fork 66
🌱 OPRUN-3955: Add experimental manifest #2063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
openshift-merge-bot
merged 1 commit into
operator-framework:main
from
tmshort:exp-std-component
Jun 28, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -73,6 +73,7 @@ endif | |||||
|
||||||
KUSTOMIZE_STANDARD_OVERLAY := config/overlays/standard | ||||||
KUSTOMIZE_STANDARD_E2E_OVERLAY := config/overlays/standard-e2e | ||||||
KUSTOMIZE_EXPERIMENTAL_OVERLAY := config/overlays/experimental | ||||||
|
||||||
export RELEASE_MANIFEST := operator-controller.yaml | ||||||
export RELEASE_INSTALL := install.sh | ||||||
|
@@ -82,6 +83,7 @@ export RELEASE_CATALOGS := default-catalogs.yaml | |||||
MANIFEST_HOME := ./manifests | ||||||
STANDARD_MANIFEST := ./manifests/standard.yaml | ||||||
STANDARD_E2E_MANIFEST := ./manifests/standard-e2e.yaml | ||||||
EXPERIMENTAL_MANIFEST := ./manifests/experimental.yaml | ||||||
CATALOGS_MANIFEST := ./manifests/default-catalogs.yaml | ||||||
|
||||||
# Manifest used by kind-deploy, which may be overridden by other targets | ||||||
|
@@ -154,6 +156,7 @@ manifests: $(CONTROLLER_GEN) $(KUSTOMIZE) #EXHELP Generate WebhookConfiguration, | |||||
mkdir -p $(MANIFEST_HOME) | ||||||
$(KUSTOMIZE) build $(KUSTOMIZE_STANDARD_OVERLAY) > $(STANDARD_MANIFEST) | ||||||
$(KUSTOMIZE) build $(KUSTOMIZE_STANDARD_E2E_OVERLAY) > $(STANDARD_E2E_MANIFEST) | ||||||
$(KUSTOMIZE) build $(KUSTOMIZE_EXPERIMENTAL_OVERLAY) > $(EXPERIMENTAL_MANIFEST) | ||||||
|
||||||
.PHONY: generate | ||||||
generate: $(CONTROLLER_GEN) #EXHELP Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations. | ||||||
|
@@ -261,15 +264,15 @@ test-e2e: run image-registry prometheus e2e e2e-metrics e2e-coverage kind-clean | |||||
.PHONY: prometheus | ||||||
prometheus: PROMETHEUS_NAMESPACE := olmv1-system | ||||||
prometheus: PROMETHEUS_VERSION := v0.83.0 | ||||||
prometheus: #HELP Deploy Prometheus into specified namespace | ||||||
prometheus: #EXHELP Deploy Prometheus into specified namespace | ||||||
./hack/test/setup-monitoring.sh $(PROMETHEUS_NAMESPACE) $(PROMETHEUS_VERSION) $(KUSTOMIZE) | ||||||
|
||||||
# The metrics.out file contains raw json data of the metrics collected during a test run. | ||||||
# In an upcoming PR, this query will be replaced with one that checks for alerts from | ||||||
# prometheus. Prometheus will gather metrics we currently query for over the test run, | ||||||
# and provide alerts from the metrics based on the rules that we set. | ||||||
.PHONY: e2e-metrics | ||||||
e2e-metrics: #HELP Request metrics from prometheus; place in ARTIFACT_PATH if set | ||||||
e2e-metrics: #EXHELP Request metrics from prometheus; place in ARTIFACT_PATH if set | ||||||
curl -X POST \ | ||||||
-H "Content-Type: application/x-www-form-urlencoded" \ | ||||||
--data 'query={pod=~"operator-controller-controller-manager-.*|catalogd-controller-manager-.*"}' \ | ||||||
|
@@ -384,6 +387,10 @@ go-build-linux: $(BINARIES) | |||||
.PHONY: run | ||||||
run: docker-build kind-cluster kind-load kind-deploy wait #HELP Build the operator-controller then deploy it into a new kind cluster. | ||||||
|
||||||
.PHONY: run-experimental | ||||||
run-experimental: SOURCE_MANIFEST := $(EXPERIMENTAL_MANIFEST) | ||||||
run-experimental: run #HELP Build the operator-controller then deploy it with the experimental manifest into a new kind cluster. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
CATD_NAMESPACE := olmv1-system | ||||||
wait: | ||||||
kubectl wait --for=condition=Available --namespace=$(CATD_NAMESPACE) deployment/catalogd-controller-manager --timeout=60s | ||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
# Does not include the CRD, which must be added separately (it's non-namespaced) | ||
apiVersion: kustomize.config.k8s.io/v1beta1 | ||
kind: Kustomization | ||
namespace: olmv1-system | ||
namePrefix: catalogd- | ||
resources: | ||
- crd | ||
- rbac | ||
- manager |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,8 @@ | ||
# Does not include the CRD, which must be added separately (it's non-namespaced) | ||
apiVersion: kustomize.config.k8s.io/v1beta1 | ||
kind: Kustomization | ||
namespace: olmv1-system | ||
namePrefix: operator-controller- | ||
resources: | ||
- crd | ||
- rbac | ||
- manager | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
apiVersion: kustomize.config.k8s.io/v1alpha1 | ||
kind: Component | ||
# resources contains the minimal required base, EXCEPT CRDs | ||
resources: | ||
- ../../../base/catalogd | ||
- ../../../base/operator-controller | ||
- ../../../base/common | ||
# components should include any GA'd features (none as of now) | ||
components: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
apiVersion: kustomize.config.k8s.io/v1alpha1 | ||
kind: Component | ||
# Pull in the experimental CRDs | ||
resources: | ||
- ../../../base/catalogd/crd/experimental | ||
- ../../../base/operator-controller/crd/experimental | ||
# Pull in the component(s) common to standard and experimental | ||
components: | ||
- ../common | ||
# EXPERIMENTAL FEATURES ARE LISTED HERE | ||
- ../../features/synthetic-user-permissions | ||
- ../../features/webhook-provider-certmanager | ||
- ../../features/webhook-provider-openshift-serviceca |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
apiVersion: kustomize.config.k8s.io/v1alpha1 | ||
kind: Component | ||
# Pull in the standard CRDs | ||
resources: | ||
- ../../../base/catalogd/crd/standard | ||
- ../../../base/operator-controller/crd/standard | ||
# Pull in the component(s) common to standard and experimental | ||
components: | ||
- ../common | ||
# GA'D FEATURES ARE LISTED HERE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# kustomization file for secure OLMv1 | ||
# DO NOT ADD A NAMESPACE HERE | ||
apiVersion: kustomize.config.k8s.io/v1beta1 | ||
kind: Kustomization | ||
components: | ||
- ../../components/base/experimental | ||
# This must be last due to namespace overwrite issues of the ca | ||
- ../../components/cert-manager |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related but very small, thank you for the catcher 👍