Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .tilt-support
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ load('ext://cert_manager', 'deploy_cert_manager')
def deploy_cert_manager_if_needed():
cert_manager_var = '__CERT_MANAGER__'
if os.getenv(cert_manager_var) != '1':
deploy_cert_manager(version="v1.15.3")
deploy_cert_manager(version="v1.18.2")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if it could read the value from the Makefile, so we do not forget to update it.
Anyway, it is a very small, nice-to-have, so I will not block this one due to it
We can improve in follow up always :-)

/lgtm

os.putenv(cert_manager_var, '1')


Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ endif
ENVTEST_VERSION := $(K8S_VERSION).x

# Define dependency versions (use go.mod if we also use Go code from dependency)
export CERT_MGR_VERSION := v1.18.1
export CERT_MGR_VERSION := v1.18.2
export WAIT_TIMEOUT := 60s

# Install default ClusterCatalogs
Expand Down
Loading