Skip to content

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Jul 3, 2025

The feature-set annotation was originally applied by the crd-generator to the generated CRDs. Now, that annotaion is being added by the overlay, and is being added to all resources in the manifest.

Each manifest has an annotation value based its name.

The crd-generator is now adding a generated annotation indicating what the CRD was generated for.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner July 3, 2025 18:13
Copy link

netlify bot commented Jul 3, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit d1276a0
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6866cea505fc0a00089e481f
😎 Deploy Preview https://deploy-preview-2073--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci bot requested review from bentito and rashmigottipati July 3, 2025 18:13
The feature-set annotation was originally applied by the crd-generator
to the generated CRDs. Now, that annotaion is being added by the overlay,
and is being added to all resources in the manifest.

Each manifest has an annotation value based its name.

The crd-generator is now adding a generated annotation indicating what
the CRD was generated for.

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
Copy link
Contributor Author

tmshort commented Jul 3, 2025

The go-apidiff issue with with the crd-generator code, and is innocuous.

@tmshort
Copy link
Contributor Author

tmshort commented Jul 3, 2025

/approve

Copy link

openshift-ci bot commented Jul 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2025
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.35%. Comparing base (5665a32) to head (d1276a0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2073      +/-   ##
==========================================
+ Coverage   73.34%   73.35%   +0.01%     
==========================================
  Files          77       77              
  Lines        7056     7056              
==========================================
+ Hits         5175     5176       +1     
+ Misses       1541     1540       -1     
  Partials      340      340              
Flag Coverage Δ
e2e 44.98% <ø> (-0.05%) ⬇️
experimental-e2e 51.34% <ø> (ø)
unit 58.27% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@camilamacedo86
Copy link
Contributor

We did not release, and that is internal, so we can ignore go-apidiff
Also, it is in the hack.

But @tmshort, could we please move the GoLang code in the hack to an internal directory to avoid it?
That would ensure safely that we do not export this staff.

I will not consider it a block but seems very nice to have
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Jul 3, 2025

I'm not sure moving it to "internal" will help, as it's not part of the operator-controller or catalogd, since it's a separate tool. All other such tools are located in hack.

@tmshort tmshort merged commit ee0d232 into operator-framework:main Jul 3, 2025
20 of 22 checks passed
@tmshort tmshort deleted the exp-annotation branch July 3, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants