-
Notifications
You must be signed in to change notification settings - Fork 66
✨ Add feature-set annotation to all manifest resources #2073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The feature-set annotation was originally applied by the crd-generator to the generated CRDs. Now, that annotaion is being added by the overlay, and is being added to all resources in the manifest. Each manifest has an annotation value based its name. The crd-generator is now adding a generated annotation indicating what the CRD was generated for. Signed-off-by: Todd Short <tshort@redhat.com>
The go-apidiff issue with with the crd-generator code, and is innocuous. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2073 +/- ##
==========================================
+ Coverage 73.34% 73.35% +0.01%
==========================================
Files 77 77
Lines 7056 7056
==========================================
+ Hits 5175 5176 +1
+ Misses 1541 1540 -1
Partials 340 340
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We did not release, and that is internal, so we can ignore go-apidiff But @tmshort, could we please move the GoLang code in the hack to an internal directory to avoid it? I will not consider it a block but seems very nice to have |
I'm not sure moving it to "internal" will help, as it's not part of the operator-controller or catalogd, since it's a separate tool. All other such tools are located in hack. |
The feature-set annotation was originally applied by the crd-generator to the generated CRDs. Now, that annotaion is being added by the overlay, and is being added to all resources in the manifest.
Each manifest has an annotation value based its name.
The crd-generator is now adding a generated annotation indicating what the CRD was generated for.
Description
Reviewer Checklist