Skip to content

Conversation

joelanford
Copy link
Member

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@joelanford joelanford requested a review from a team as a code owner September 9, 2025 02:00
@openshift-ci openshift-ci bot requested review from dtfranz and OchiengEd September 9, 2025 02:00
Copy link

netlify bot commented Sep 9, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 068b71b
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68c09d111e50b80009cdbf31
😎 Deploy Preview https://deploy-preview-2202--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tmshort
Copy link
Contributor

tmshort commented Sep 9, 2025

Per the errors in the CI, he empty go.mod may still require a package name.

Copy link
Contributor

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR can just retract the v1.5.0 and we can dynamically create the containerd config #2203

@tmshort
Copy link
Contributor

tmshort commented Sep 9, 2025

We ought to pick one, this, or #2203

Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.12%. Comparing base (68610d0) to head (068b71b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2202      +/-   ##
==========================================
+ Coverage   72.05%   72.12%   +0.06%     
==========================================
  Files          85       85              
  Lines        8332     8401      +69     
==========================================
+ Hits         6004     6059      +55     
- Misses       1926     1939      +13     
- Partials      402      403       +1     
Flag Coverage Δ
e2e 39.47% <ø> (+0.01%) ⬆️
experimental-e2e 46.26% <ø> (+0.02%) ⬆️
unit 56.85% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…om root module

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
Copy link
Contributor

tmshort commented Sep 9, 2025

/approve

Copy link

openshift-ci bot commented Sep 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2025
@anik120
Copy link
Contributor

anik120 commented Sep 9, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2025
@anik120 anik120 merged commit 67098e7 into operator-framework:main Sep 9, 2025
21 of 23 checks passed
@joelanford joelanford deleted the fix-go-mod-zip branch September 10, 2025 12:55
joelanford added a commit to joelanford/operator-controller that referenced this pull request Sep 10, 2025
…ot module (operator-framework#2202)

* retract v1.5.0; exclude hack/kind-config/containerd/certs.d from root module

* fixup! retract v1.5.0; exclude hack/kind-config/containerd/certs.d from root module

* fixup! retract v1.5.0; exclude hack/kind-config/containerd/certs.d from root module

Signed-off-by: Todd Short <tshort@redhat.com>

---------

Signed-off-by: Todd Short <tshort@redhat.com>
Co-authored-by: Todd Short <tshort@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants