Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumping to k8s 1.25 #109

Merged
merged 6 commits into from
Sep 20, 2022
Merged

Bumping to k8s 1.25 #109

merged 6 commits into from
Sep 20, 2022

Conversation

jmrodri
Copy link
Member

@jmrodri jmrodri commented Sep 1, 2022

Description of the change:

Bumping to k8s v1.25

Motivation for the change:

@jmrodri
Copy link
Member Author

jmrodri commented Sep 1, 2022

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2022
@jmrodri
Bumping to k8s 1.25 & go 1.19
3a22919 
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
@jmrodri
Copy link
Member Author

jmrodri commented Sep 2, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2022
@jmrodri
Bump ci to go 1.19
baffadc 
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
@coveralls
Copy link

coveralls commented Sep 3, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3038674967

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.767%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/utils/utils.go 0 1 0.0%
Totals Coverage Status
Change from base Build 2959748888: 0.0%
Covered Lines: 601
Relevant Lines: 709
💛 - Coveralls

@jmrodri
Bump golangci-lint & fix linter errors
3d28851 
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
@jmrodri
Setup go for lint call.
e5200e2 
The github action with the newer linter needs go setup for it to run
properly.

Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
@jmrodri
Remove deprecated -i flag from go build
00e118a 
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
@jmrodri
Copy link
Member Author

jmrodri commented Sep 5, 2022

In the process of updating k8s to 1.25, we had to bump go to 1.19. That resulted in also bumping golangci-lint to 1.49 and fixing the github action. This PR is currently blocked by the prow test all call, that was configured for go 1.17 which I bumped to 1.19 right now. Blocked by openshift/release#31977

@jmrodri
Copy link
Member Author

jmrodri commented Sep 13, 2022

/test test-all

@laxmikantbpandhare laxmikantbpandhare mentioned this pull request Sep 15, 2022
Closed
13 tasks
@jmrodri
Copy link
Member Author

jmrodri commented Sep 20, 2022

/test test-all

asmacdo
asmacdo approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@asmacdo asmacdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2022
@jmrodri
Copy link
Member Author

jmrodri commented Sep 20, 2022

As of go 1.19 ioutil has been deprecated. They introduced the same functionality in os starting in go 1.16. https://pkg.go.dev/io/ioutil@go1.19.1

@asmacdo
Copy link
Member

asmacdo commented Sep 20, 2022

/approved

@asmacdo
Copy link
Member

asmacdo commented Sep 20, 2022

/approve

1 similar comment
@jmrodri
Copy link
Member Author

jmrodri commented Sep 20, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asmacdo, jmrodri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2022
@openshift-merge-robot openshift-merge-robot merged commit 1ab78cc into operator-framework:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmacdo asmacdo asmacdo approved these changes

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

@theishshah theishshah Awaiting requested review from theishshah

Assignees

@asmacdo asmacdo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmrodri @coveralls @asmacdo @openshift-merge-robot