🌱 bump kube to 0.31.0, controller-runtime to v0.19.0, and fix generics issues #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
==========================================
- Coverage 88.88% 88.86% -0.02%
==========================================
Files 18 18
Lines 576 575 -1
==========================================
- Hits 512 511 -1
Misses 51 51
Partials 13 13 ☔ View full report in Codecov by Sentry. |
…s issues Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
perdasilva
force-pushed
the
perdasilva/bumpk8s
branch
from
e344cbe
to
e326148
Compare
10 tasks
acornett21
reviewed
Aug 22, 2024
| @@ -85,17 +85,17 @@ type EnqueueRequestForAnnotation[T client.Object] struct { | |||
| Type schema.GroupKind | |||
| } | |||
|
|
|||
| var _ crtHandler.EventHandler = &EnqueueRequestForAnnotation[client.Object]{} | |||
| var _ crtHandler.TypedEventHandler[client.Object, reconcile.Request] = &EnqueueRequestForAnnotation[client.Object]{} | |||
There was a problem hiding this comment.
Internally EventHandler was already updated to be this type. Does this have to change?
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This was referenced Aug 27, 2024
|
Closing in favor of #192 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Bumps kube to v0.31.0 and controller-runtime to v0.19.0. Fixes deprecations and changes. Though, client-go has introduced some new interfaces and retired old ones. Hence, the API diff job failure.
Motivation for the change:
bring the library to the latest kube version