Skip to content

Commit

Permalink
Revert "Fix Image Update test"
Browse files Browse the repository at this point in the history
This reverts commit f7b970e.

Signed-off-by: Alexander Greene <greene.al1991@gmail.com>
  • Loading branch information
awgreene authored and stevekuznetsov committed Nov 9, 2023
1 parent e8afbf7 commit 17b9103
Showing 1 changed file with 0 additions and 27 deletions.
27 changes: 0 additions & 27 deletions test/e2e/catalog_e2e_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import (
. "github.com/onsi/gomega"
appsv1 "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
rbacv1 "k8s.io/api/rbac/v1"
"k8s.io/apimachinery/pkg/api/meta"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/labels"
Expand Down Expand Up @@ -924,32 +923,6 @@ var _ = Describe("Starting CatalogSource e2e tests", func() {
Expect(registryPods).ShouldNot(BeNil(), "nil registry pods")
Expect(registryPods.Items).To(HaveLen(1), "unexpected number of registry pods found")

By("Granting the ServiceAccount used by the registry pod permissions to pull from the internal registry")
roleBinding := &rbacv1.RoleBinding{
ObjectMeta: metav1.ObjectMeta{
Namespace: generatedNamespace.GetName(),
GenerateName: "registry-v1-viewer-",
},
Subjects: []rbacv1.Subject{
{
Kind: "ServiceAccount",
Name: registryPods.Items[0].Spec.ServiceAccountName,
APIGroup: "",
},
},
RoleRef: rbacv1.RoleRef{
Kind: "ClusterRole",
Name: "registry-viewer",
APIGroup: "rbac.authorization.k8s.io",
},
}
_, err = c.CreateRoleBinding(roleBinding)
Expect(err).ToNot(HaveOccurred(), "error granting registry-viewer permissions")
defer func() {
err := c.DeleteRoleBinding(roleBinding.GetNamespace(), roleBinding.GetName(), &metav1.DeleteOptions{})
Expect(err).ShouldNot(HaveOccurred())
}()

By("Create a Subscription for package")
subscriptionName := genName("sub-")
cleanupSubscription := createSubscriptionForCatalog(crc, source.GetNamespace(), subscriptionName, source.GetName(), packageName, channelName, "", v1alpha1.ApprovalAutomatic)
Expand Down

0 comments on commit 17b9103

Please sign in to comment.