-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1819308: Deleting a CSV removes related CSV metrics #1525
Bug 1819308: Deleting a CSV removes related CSV metrics #1525
Conversation
Problem: Bug 1819308: When creating a CSV fails, deleting it did not clear the CSV metrics. So when the same CSV was created again and allowed to succeed, the olm pod still retained the old CSV metrics Solution: Deleting a CSV will now clear its related metrics from the olm pod Signed-off-by: Harish <hgovinda@redhat.com>
@harishsurf: This pull request references Bugzilla bug 1819308, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
waiting on #1439 to merge to restructure the e2e test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, harishsurf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@harishsurf: All pull requests linked via external trackers have merged: operator-framework/operator-lifecycle-manager#1525. Bugzilla bug 1819308 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hey guys, in which release will this fix be available? |
@jjaferson we're in the process of cutting a 0.15.1 release. This fix will be available as soon as the 0.15.1 is up in a couple of hours. |
/cherry-pick release-4.3 |
@harishsurf: #1525 failed to apply on top of branch "release-4.3":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Problem: When creating a CSV fails, deleting it did
not clear the CSV metrics. So, when the same CSV was created
again and allowed to succeed, the olm pod still retained the
old CSV metrics
Solution: Added a new method that deletes the CSV metrics when the CSV gets deleted
Signed-off-by: Harish hgovinda@redhat.com
Description of the change:
Motivation for the change:
Reviewer Checklist
/docs