feat(operator): adopt referenced installplans #1661

njhale · 2020-07-21T14:31:24Z

Adopt InstallPlans to the Operator(s) represented by the Subscriptions
that reference them. This means that InstallPlans are components of the
operators they install.

openshift-ci-robot · 2020-07-21T14:31:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [njhale]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

njhale · 2020-07-21T16:52:12Z

/retest

exdx · 2020-07-22T19:49:58Z

Is this at all impacted by #1669

njhale · 2020-07-23T15:09:23Z

Is this at all impacted by #1669

It shouldn't be. This adopts the latest InstallPlan referenced by a Subscription.

njhale · 2020-07-23T17:23:56Z

/retest

ecordell · 2020-07-27T10:18:33Z

pkg/controller/operators/adoption_controller.go

+		ip := &operatorsv1alpha1.InstallPlan{}
+		ip.SetNamespace(ref.Namespace)
+		ip.SetName(ref.Name)
+		if err := r.adopt(ctx, operator, ip); err != nil {


Am I missing where the installplan would be "unadopted" when it is no longer the current one?

Nope, we don't disown InstallPlans. Is there a reason to do so now that we have a cap on the number that can exist at a given time?

njhale · 2020-07-28T14:17:25Z

/retest

njhale · 2020-07-30T20:07:53Z

/retest

njhale · 2020-07-30T21:56:16Z

/retest

njhale · 2020-07-31T01:55:40Z

/retest

ecordell · 2020-07-31T12:51:43Z

pkg/controller/operators/adoption_controller.go

-	// TODO(njhale): parallelize
+	var (
+		errs []error
+		mu   sync.Mutex


why not an error channel instead of a mutex + err slice?

Adopt InstallPlans to the Operator(s) represented by the Subscriptions that reference them. This means that InstallPlans are components of the operators they install.

ecordell · 2020-07-31T13:51:49Z

/lgtm

Bowenislandsong · 2020-07-31T14:34:51Z

This PR failed tests for 1 times with 7 individual failed tests and 4 skipped tests. A test is considered flaky if failed on multiple commits.

totaltestcount: 1
flaketestcount: 7
skippedtestcount: 4
flaketests:

classname: End-to-end
name: 'User defined service account with permission'
counts: 3
details:
- count: 3
  error: "\n\n/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/user_defined_sa_test.go:82\n\n\tError
  Trace:\tuser_defined_sa_test.go:134\n\t \t\t\t\trunner.go:113\n\t
  \ \t\t\t\trunner.go:64\n\t \t\t\t\tit_node.go:26\n\t
  \ \t\t\t\tspec.go:215\n\t \t\t\t\tspec.go:138\n\t
  \ \t\t\t\tspec_runner.go:200\n\t \t\t\t\tspec_runner.go:170\n\t
  \ \t\t\t\tspec_runner.go:66\n\t \t\t\t\tsuite.go:62\n\t
  \ \t\t\t\tginkgo_dsl.go:226\n\t \t\t\t\tginkgo_dsl.go:214\n\t
  \ \t\t\t\te2e_test.go:54\n\tError: \tNot equal: \n\t \texpected:
  "Created"\n\t \tactual : "Present"\n\t \t\n\t
  \ \tDiff:\n\t \t--- Expected\n\t \t+++
  Actual\n\t \t@@ -1,2 +1,2 @@\n\t \t-(v1alpha1.StepStatus)
  (len=7) "Created"\n\t \t+(v1alpha1.StepStatus) (len=7) "Present"\n\t
  \ \t \n\n/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/user_defined_sa_test.go:134"
  meandurationsec: 34.58998

classname: End-to-end
name: 'CRD Versions allows a CRD upgrade that doesn''t cause data loss'
counts: 1
details:

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/crd_e2e_test.go:345
Timed out after 60.000s.
Expected
    <bool>: false
to be true
/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/crd_e2e_test.go:516

meandurationsec: 83.847514

classname: End-to-end
name: 'Catalog gRPC address catalog source'
counts: 1
details:

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/catalog_e2e_test.go:34
Timed out after 60.001s.
failed to await deletion of test csvs
Expected
    <[]v1alpha1.ClusterServiceVersion | len:1, cap:1>: [
        {
            TypeMeta: {
                Kind: "ClusterServiceVersion",
                APIVersion: "operators.coreos.com/v1alpha1",
            },
            ObjectMeta: {
                Name: "nginx-rzl6b-stable-replacement",
                GenerateName: "",
                Namespace: "operators",
                SelfLink: "/apis/operators.coreos.com/v1alpha1/namespaces/operators/clusterserviceversions/nginx-rzl6b-stable-replacement",
                UID: "7c448146-df5a-4584-a0c7-1adc4f1bd39c",
                ResourceVersion: "9274",
                Generation: 1,
                CreationTimestamp: {
                    Time: 2020-07-31T14:12:12Z,
                },
                DeletionTimestamp: nil,
                DeletionGracePeriodSeconds: nil,
                Labels: {
                    "olm.api.bdaab1e188d62512": "required",
                },
                Annotations: {
                    "olm.targetNamespaces": "",
                    "olm.operatorGroup": "global-operators",
                    "olm.operatorNamespace": "operators",
                },
                OwnerReferences: nil,
                Finalizers: nil,
                ClusterName: "",
                ManagedFields: nil,
            },
            Spec: {
                InstallStrategy: {
                    StrategyName: "deployment",
                    StrategySpec: {
                        DeploymentSpecs: [
                            {
                                Name: "depvk4jk",
                                Spec: {
                                    Replicas: 1,
                                    Selector: {
                                        MatchLabels: {...: ...},
                                        MatchExpressions: nil,
                                    },
                                    Template: {
                                        ObjectMeta: {
                                            Name: ...,
                                            GenerateName: ...,
                                            Namespace: ...,
                                            SelfLink: ...,
                                            UID: ...,
                                            ResourceVersion: ...,
                                            Generation: ...,
                                            CreationTimestamp: ...,
                                            DeletionTimestamp: ...,
                                            DeletionGracePeriodSeconds: ...,
                                            Labels: ...,
                                            Annotations: ...,
                                            OwnerReferences: ...,
                                            Finalizers: ...,
                                            ClusterName: ...,
                                            ManagedFields: ...,
                                        },
                                        Spec: {
                                            Volumes: ...,
                                            InitContainers: ...,
                                            Containers: ...,
                                            EphemeralContainers: ...,
                                            RestartPolicy: ...,
                                            TerminationGracePeriodSeconds: ...,
                                            ActiveDeadlineSeconds: ...,
                                            DNSPolicy: ...,
                                            NodeSelector: ...,
                                            ServiceAccountName: ...,
                                            DeprecatedServiceAccount: ...,
                                            AutomountServiceAccountToken: ...,
                                            NodeName: ...,
                                            HostNetwork: ...,
                                            HostPID: ...,
                                            HostIPC: ...,
                                            ShareProcessNamespace: ...,
                                            SecurityContext: ...,
                                            ImagePullSecrets: ...,
                                            Hostname: ...,
                                            Subdomain: ...,
                                            Affinity: ...,
                                            SchedulerName: ...,
                                            Tolerations: ...,
                                            HostAliases: ...,
                                            PriorityClassName: ...,
                                            Priority: ...,
                                            DNSConfig: ...,
                                            ReadinessGates: ...,
                                            RuntimeClassName: ...,
                                            EnableServiceLinks: ...,
                                            PreemptionPolicy: ...,
                                            Overhead: ...,
                                            TopologySpreadConstraints: ...,
                                        },
                                    },
                                    Strategy: {Type: "", RollingUpdate: nil},
                                    MinReadySeconds: 0,
                                    RevisionHistoryLimit: nil,
                                    Paused: false,
                                    ProgressDeadlineSeconds: nil,
                                },
                                Label: nil,
                            },
                        ],
                        Permissions: nil,
                        ClusterPermissions: nil,
                    },
                },
                Version: {
                    Version: {Major: 0, Minor: 2, Patch: 0, Pre: nil, Build: nil},
                },
                Maturity: "",
                CustomResourceDefinitions: {
                    Owned: nil,
                    Required: [
                        {
                            Name: "ins-rg4ll.cluster.com",
                            Version: "v1alpha1",
                            Kind: "ins-rg4ll",
                            DisplayName: "ins-rg4ll.cluster.com",
                            Description: "ins-rg4ll.cluster.com",
                            Resources: nil,
                            StatusDescriptors: nil,
                            SpecDescriptors: nil,
                            ActionDescriptor: nil,
                        },
                    ],
                },
                APIServiceDefinitions: {Owned: nil, Required: nil},
                WebhookDefinitions: nil,
                NativeAPIs: nil,
                MinKubeVersion: "0.0.0",
                DisplayName: "",
                Description: "",
                Keywords: nil,
                Maintainers: nil,
                Provider: {Name: "", URL: ""},
                Links: nil,
                Icon: nil,
                InstallModes: [
                    {Type: "OwnNamespace", Supported: true},
                    {
                        Type: "SingleNamespace",
                        Supported: true,
                    },
                    {
                        Type: "MultiNamespace",
                        Supported: true,
                    },
                    {
                        Type: "AllNamespaces",
                        Supported: true,
                    },
                ],
                Replaces: "nginx-rzl6b-stable",
                Labels: nil,
                Annotations: nil,
                Selector: nil,
            },
            Status: {
                Phase: "Pending",
                Message: "one or more requirements couldn't be found",
                Reason: "RequirementsNotMet",
                LastUpdateTime: {
                    Time: 2020-07-31T14:12:13Z,
                },
                LastTransitionTime: {
                    Time: 2020-07-31T14:12:12Z,
                },
                Conditions: [
                    {
                        Phase: "Pending",
                        Message: "requirements not yet checked",
                        Reason: "RequirementsUnknown",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:12:12Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:12:12Z,
                        },
                    },
                    {
                        Phase: "Pending",
                        Message: "one or more requirements couldn't be found",
                        Reason: "RequirementsNotMet",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:12:13Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:12:12Z,
                        },
                    },
                ],
                RequirementStatus: [
                    {
                        Group: "operators.coreos.com",
                        Version: "v1alpha1",
                        Kind: "ClusterServiceVersion",
                        Name: "nginx-rzl6b-stable-replacement",
                        Status: "Present",
                        Message: "CSV minKubeVersion (0.0.0) less than server version (v1.17.0)",
                        UUID: "",
                        Dependents: nil,
                    },
                    {
                        Group: "apiextensions.k8s.io",
                        Version: "v1",
                        Kind: "CustomResourceDefinition",
                        Name: "ins-rg4ll.cluster.com",
                        Status: "NotPresent",
                        Message: "CRD is not present",
                        UUID: "",
                        Dependents: nil,
                    },
                ],
                CertsLastUpdated: nil,
                CertsRotateAt: nil,
            },
        },
    ]
to be empty
/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/util_test.go:496

meandurationsec: 124.522588

classname: End-to-end
name: 'Subscription creation in case of transferring providedAPIs'
counts: 1
details:

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/subscription_e2e_test.go:1379

	Error Trace:	subscription_e2e_test.go:1520
	            				runner.go:113
	            				runner.go:64
	            				it_node.go:26
	            				spec.go:215
	            				spec.go:138
	            				spec_runner.go:200
	            				spec_runner.go:170
	            				spec_runner.go:66
	            				suite.go:62
	            				ginkgo_dsl.go:226
	            				ginkgo_dsl.go:214
	            				e2e_test.go:54
	Error:      	Received unexpected error:
	            	clusterserviceversions.operators.coreos.com "nginx-new-a" not found

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/stretchr/testify/require/require.go:1005

meandurationsec: 87.336028

classname: End-to-end
name: 'Install Plan creation with pre existing CRD owners PreExistingCRDOwnerIsReplaced'
counts: 1
details:

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:324

	Error Trace:	installplan_e2e_test.go:433
	            				runner.go:113
	            				runner.go:64
	            				it_node.go:26
	            				spec.go:215
	            				spec.go:138
	            				spec_runner.go:200
	            				spec_runner.go:170
	            				spec_runner.go:66
	            				suite.go:62
	            				ginkgo_dsl.go:226
	            				ginkgo_dsl.go:214
	            				e2e_test.go:54
	Error:      	Received unexpected error:
	            	timed out waiting for the condition

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/stretchr/testify/require/require.go:1005

meandurationsec: 322.683414

classname: End-to-end
name: 'Subscription creation with dependencies required and provided in different
versions of an operator in the same package'
counts: 1
details:

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/subscription_e2e_test.go:46
Timed out after 60.001s.
failed to await deletion of test csvs
Expected
    <[]v1alpha1.ClusterServiceVersion | len:3, cap:4>: [
        {
            TypeMeta: {
                Kind: "ClusterServiceVersion",
                APIVersion: "operators.coreos.com/v1alpha1",
            },
            ObjectMeta: {
                Name: "csv-a",
                GenerateName: "",
                Namespace: "operators",
                SelfLink: "/apis/operators.coreos.com/v1alpha1/namespaces/operators/clusterserviceversions/csv-a",
                UID: "a1d5fa2b-4631-43da-b57c-a660df1f6ae8",
                ResourceVersion: "10500",
                Generation: 1,
                CreationTimestamp: {
                    Time: 2020-07-31T14:18:06Z,
                },
                DeletionTimestamp: nil,
                DeletionGracePeriodSeconds: nil,
                Labels: {
                    "olm.api.9114e1a0f3d7c7f2": "required",
                    "olm.api.c522b75b77c4de0a": "required",
                },
                Annotations: {
                    "olm.operatorGroup": "global-operators",
                    "olm.operatorNamespace": "operators",
                    "olm.targetNamespaces": "",
                },
                OwnerReferences: nil,
                Finalizers: nil,
                ClusterName: "",
                ManagedFields: nil,
            },
            Spec: {
                InstallStrategy: {
                    StrategyName: "deployment",
                    StrategySpec: {
                        DeploymentSpecs: [
                            {
                                Name: "depw88xf",
                                Spec: {
                                    Replicas: 1,
                                    Selector: {
                                        MatchLabels: {...: ...},
                                        MatchExpressions: nil,
                                    },
                                    Template: {
                                        ObjectMeta: {
                                            Name: ...,
                                            GenerateName: ...,
                                            Namespace: ...,
                                            SelfLink: ...,
                                            UID: ...,
                                            ResourceVersion: ...,
                                            Generation: ...,
                                            CreationTimestamp: ...,
                                            DeletionTimestamp: ...,
                                            DeletionGracePeriodSeconds: ...,
                                            Labels: ...,
                                            Annotations: ...,
                                            OwnerReferences: ...,
                                            Finalizers: ...,
                                            ClusterName: ...,
                                            ManagedFields: ...,
                                        },
                                        Spec: {
                                            Volumes: ...,
                                            InitContainers: ...,
                                            Containers: ...,
                                            EphemeralContainers: ...,
                                            RestartPolicy: ...,
                                            TerminationGracePeriodSeconds: ...,
                                            ActiveDeadlineSeconds: ...,
                                            DNSPolicy: ...,
                                            NodeSelector: ...,
                                            ServiceAccountName: ...,
                                            DeprecatedServiceAccount: ...,
                                            AutomountServiceAccountToken: ...,
                                            NodeName: ...,
                                            HostNetwork: ...,
                                            HostPID: ...,
                                            HostIPC: ...,
                                            ShareProcessNamespace: ...,
                                            SecurityContext: ...,
                                            ImagePullSecrets: ...,
                                            Hostname: ...,
                                            Subdomain: ...,
                                            Affinity: ...,
                                            SchedulerName: ...,
                                            Tolerations: ...,
                                            HostAliases: ...,
                                            PriorityClassName: ...,
                                            Priority: ...,
                                            DNSConfig: ...,
                                            ReadinessGates: ...,
                                            RuntimeClassName: ...,
                                            EnableServiceLinks: ...,
                                            PreemptionPolicy: ...,
                                            Overhead: ...,
                                            TopologySpreadConstraints: ...,
                                        },
                                    },
                                    Strategy: {Type: "", RollingUpdate: nil},
                                    MinReadySeconds: 0,
                                    RevisionHistoryLimit: nil,
                                    Paused: false,
                                    ProgressDeadlineSeconds: nil,
                                },
                                Label: nil,
                            },
                        ],
                        Permissions: nil,
                        ClusterPermissions: nil,
                    },
                },
                Version: {
                    Version: {Major: 0, Minor: 1, Patch: 0, Pre: nil, Build: nil},
                },
                Maturity: "",
                CustomResourceDefinitions: {
                    Owned: nil,
                    Required: [
                        {
                            Name: "insdscfv.cluster.com",
                            Version: "v1alpha1",
                            Kind: "insdscfv",
                            DisplayName: "insdscfv.cluster.com",
                            Description: "insdscfv.cluster.com",
                            Resources: nil,
                            StatusDescriptors: nil,
                            SpecDescriptors: nil,
                            ActionDescriptor: nil,
                        },
                        {
                            Name: "insjp8jz.cluster.com",
                            Version: "v1alpha1",
                            Kind: "insjp8jz",
                            DisplayName: "insjp8jz.cluster.com",
                            Description: "insjp8jz.cluster.com",
                            Resources: nil,
                            StatusDescriptors: nil,
                            SpecDescriptors: nil,
                            ActionDescriptor: nil,
                        },
                    ],
                },
                APIServiceDefinitions: {Owned: nil, Required: nil},
                WebhookDefinitions: nil,
                NativeAPIs: nil,
                MinKubeVersion: "0.0.0",
                DisplayName: "",
                Description: "",
                Keywords: nil,
                Maintainers: nil,
                Provider: {Name: "", URL: ""},
                Links: nil,
                Icon: nil,
                InstallModes: [
                    {Type: "OwnNamespace", Supported: true},
                    {
                        Type: "SingleNamespace",
                        Supported: true,
                    },
                    {
                        Type: "MultiNamespace",
                        Supported: true,
                    },
                    {
                        Type: "AllNamespaces",
                        Supported: true,
                    },
                ],
                Replaces: "",
                Labels: nil,
                Annotations: nil,
                Selector: nil,
            },
            Status: {
                Phase: "Succeeded",
                Message: "install strategy completed with no errors",
                Reason: "InstallSucceeded",
                LastUpdateTime: {
                    Time: 2020-07-31T14:18:10Z,
                },
                LastTransitionTime: {
                    Time: 2020-07-31T14:18:10Z,
                },
                Conditions: [
                    {
                        Phase: "Pending",
                        Message: "requirements not yet checked",
                        Reason: "RequirementsUnknown",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:18:06Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:18:06Z,
                        },
                    },
                    {
                        Phase: "Pending",
                        Message: "one or more requirements couldn't be found",
                        Reason: "RequirementsNotMet",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:18:06Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:18:06Z,
                        },
                    },
                    {
                        Phase: "InstallReady",
                        Message: "all requirements found, attempting install",
                        Reason: "AllRequirementsMet",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:18:06Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:18:06Z,
                        },
                    },
                    {
                        Phase: "Installing",
                        Message: "waiting for install components to report healthy",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:18:07Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:18:07Z,
                        },
                    },
                    {
                        Phase: "Installing",
                        Message: "installing: waiting for deployment depw88xf to become ready: Waiting for rollout to finish: 0 of 1 updated replicas are available...\n",
                        Reason: "InstallWaiting",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:18:07Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:18:07Z,
                        },
                    },
                    {
                        Phase: "Succeeded",
                        Message: "install strategy completed with no errors",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:18:10Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:18:10Z,
                        },
                    },
                ],
                RequirementStatus: [
                    {
                        Group: "operators.coreos.com",
                        Version: "v1alpha1",
                        Kind: "ClusterServiceVersion",
                        Name: "csv-a",
                        Status: "Present",
                        Message: "CSV minKubeVersion (0.0.0) less than server version (v1.17.0)",
                        UUID: "",
                        Dependents: nil,
                    },
                    {
                        Group: "apiextensions.k8s.io",
                        Version: "v1",
                        Kind: "CustomResourceDefinition",
                        Name: "insdscfv.cluster.com",
                        Status: "Present",
                        Message: "CRD is present and Established condition is true",
                        UUID: "135b4081-3dbb-44cf-b163-53327a18fae4",
                        Dependents: nil,
                    },
                    {
                        Group: "apiextensions.k8s.io",
                        Version: "v1",
                        Kind: "CustomResourceDefinition",
                        Name: "insjp8jz.cluster.com",
                        Status: "Present",
                        Message: "CRD is present and Established condition is true",
                        UUID: "d778e80d-7611-456e-98ae-9a998a9f4c91",
                        Dependents: nil,
                    },
                ],
                CertsLastUpdated: nil,
                CertsRotateAt: nil,
            },
        },
        {
            TypeMeta: {
                Kind: "ClusterServiceVersion",
                APIVersion: "operators.coreos.com/v1alpha1",
            },
            ObjectMeta: {
                Name: "csv-b",
                GenerateName: "",
                Namespace: "operators",
                SelfLink: "/apis/operators.coreos.com/v1alpha1/namespaces/operators/clusterserviceversions/csv-b",
                UID: "9ae89125-d668-45dc-9bdb-ba18b60ab9f1",
                ResourceVersion: "10521",
                Generation: 1,
                CreationTimestamp: {
                    Time: 2020-07-31T14:18:06Z,
                },
                DeletionTimestamp: nil,
                DeletionGracePeriodSeconds: nil,
                Labels: {
                    "olm.api.c522b75b77c4de0a": "provided",
                },
                Annotations: {
                    "olm.operatorGroup": "global-operators",
                    "olm.operatorNamespace": "operators",
                    "olm.targetNamespaces": "",
                },
                OwnerReferences: nil,
                Finalizers: nil,
                ClusterName: "",
                ManagedFields: nil,
            },
            Spec: {
                InstallStrategy: {
                    StrategyName: "deployment",
                    StrategySpec: {
                        DeploymentSpecs: [
                            {
                                Name: "deptfp5c",
                                Spec: {
                                    Replicas: 1,
                                    Selector: {
                                        MatchLabels: {...: ...},
                                        MatchExpressions: nil,
                                    },
                                    Template: {
                                        ObjectMeta: {
                                            Name: ...,
                                            GenerateName: ...,
                                            Namespace: ...,
                                            SelfLink: ...,
                                            UID: ...,
                                            ResourceVersion: ...,
                                            Generation: ...,
                                            CreationTimestamp: ...,
                                            DeletionTimestamp: ...,
                                            DeletionGracePeriodSeconds: ...,
                                            Labels: ...,
                                            Annotations: ...,
                                            OwnerReferences: ...,
                                            Finalizers: ...,
                                            ClusterName: ...,
                                            ManagedFields: ...,
                                        },
                                        Spec: {
                                            Volumes: ...,
                                            InitContainers: ...,
                                            Containers: ...,
                                            EphemeralContainers: ...,
                                            RestartPolicy: ...,
                                            TerminationGracePeriodSeconds: ...,
                                            ActiveDeadlineSeconds: ...,
                                            DNSPolicy: ...,
                                            NodeSelector: ...,
                                            ServiceAccountName: ...,
                                            DeprecatedServiceAccount: ...,
                                            AutomountServiceAccountToken: ...,
                                            NodeName: ...,
                                            HostNetwork: ...,
                                            HostPID: ...,
                                            HostIPC: ...,
                                            ShareProcessNamespace: ...,
                                            SecurityContext: ...,
                                            ImagePullSecrets: ...,
                                            Hostname: ...,
                                            Subdomain: ...,
                                            Affinity: ...,
                                            SchedulerName: ...,
                                            Tolerations: ...,
                                            HostAliases: ...,
                                            PriorityClassName: ...,
                                            Priority: ...,
                                            DNSConfig: ...,
                                            ReadinessGates: ...,
                                            RuntimeClassName: ...,
                                            EnableServiceLinks: ...,
                                            PreemptionPolicy: ...,
                                            Overhead: ...,
                                            TopologySpreadConstraints: ...,
                                        },
                                    },
                                    Strategy: {Type: "", RollingUpdate: nil},
                                    MinReadySeconds: 0,
                                    RevisionHistoryLimit: nil,
                                    Paused: false,
                                    ProgressDeadlineSeconds: nil,
                                },
                                Label: nil,
                            },
                        ],
                        Permissions: nil,
                        ClusterPermissions: nil,
                    },
                },
                Version: {
                    Version: {Major: 0, Minor: 1, Patch: 0, Pre: nil, Build: nil},
                },
                Maturity: "",
                CustomResourceDefinitions: {
                    Owned: [
                        {
                            Name: "insdscfv.cluster.com",
                            Version: "v1alpha1",
                            Kind: "insdscfv",
                            DisplayName: "insdscfv.cluster.com",
                            Description: "insdscfv.cluster.com",
                            Resources: nil,
                            StatusDescriptors: nil,
                            SpecDescriptors: nil,
                            ActionDescriptor: nil,
                        },
                    ],
                    Required: nil,
                },
                APIServiceDefinitions: {Owned: nil, Required: nil},
                WebhookDefinitions: nil,
                NativeAPIs: nil,
                MinKubeVersion: "0.0.0",
                DisplayName: "",
                Description: "",
                Keywords: nil,
                Maintainers: nil,
                Provider: {Name: "", URL: ""},
                Links: nil,
                Icon: nil,
                InstallModes: [
                    {Type: "OwnNamespace", Supported: true},
                    {
                        Type: "SingleNamespace",
                        Supported: true,
                    },
                    {
                        Type: "MultiNamespace",
                        Supported: true,
                    },
                    {
                        Type: "AllNamespaces",
                        Supported: true,
                    },
                ],
                Replaces: "",
                Labels: nil,
                Annotations: nil,
                Selector: nil,
            },
            Status: {
                Phase: "Succeeded",
                Message: "install strategy completed with no errors",
                Reason: "InstallSucceeded",
                LastUpdateTime: {
                    Time: 2020-07-31T14:18:11Z,
                },
                LastTransitionTime: {
                    Time: 2020-07-31T14:18:11Z,
                },
                Conditions: [
                    {
                        Phase: "Pending",
                        Message: "requirements not yet checked",
                        Reason: "RequirementsUnknown",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:18:07Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:18:07Z,
                        },
                    },
                    {
                        Phase: "InstallReady",
                        Message: "all requirements found, attempting install",
                        Reason: "AllRequirementsMet",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:18:07Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:18:07Z,
                        },
                    },
                    {
                        Phase: "Installing",
                        Message: "waiting for install components to report healthy",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:18:07Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:18:07Z,
                        },
                    },
                    {
                        Phase: "Installing",
                        Message: "installing: waiting for deployment deptfp5c to become ready: Waiting for rollout to finish: 0 out of 1 new replicas have been updated...\n",
                        Reason: "InstallWaiting",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:18:09Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:18:07Z,
                        },
                    },
                    {
                        Phase: "Succeeded",
                        Message: "install strategy completed with no errors",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:18:11Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:18:11Z,
                        },
                    },
                ],
                RequirementStatus: [
                    {
                        Group: "operators.coreos.com",
                        Version: "v1alpha1",
                        Kind: "ClusterServiceVersion",
                        Name: "csv-b",
                        Status: "Present",
                        Message: "CSV minKubeVersion (0.0.0) less than server version (v1.17.0)",
                        UUID: "",
                        Dependents: nil,
                    },
                    {
                        Group: "apiextensions.k8s.io",
                        Version: "v1",
                        Kind: "CustomResourceDefinition",
                        Name: "insdscfv.cluster.com",
                        Status: "Present",
                        Message: "CRD is present and Established condition is true",
                        UUID: "135b4081-3dbb-44cf-b163-53327a18fae4",
                        Dependents: nil,
                    },
                ],
                CertsLastUpdated: nil,
                CertsRotateAt: nil,
            },
        },
        {
            TypeMeta: {
                Kind: "ClusterServiceVersion",
                APIVersion: "operators.coreos.com/v1alpha1",
            },
            ObjectMeta: {
                Name: "csv-e",
                GenerateName: "",
                Namespace: "operators",
                SelfLink: "/apis/operators.coreos.com/v1alpha1/namespaces/operators/clusterserviceversions/csv-e",
                UID: "d6ecaa1c-c4bc-4772-b503-0d5c3c9fc6a9",
                ResourceVersion: "10527",
                Generation: 1,
                CreationTimestamp: {
                    Time: 2020-07-31T14:18:05Z,
                },
                DeletionTimestamp: nil,
                DeletionGracePeriodSeconds: nil,
                Labels: {
                    "olm.api.9114e1a0f3d7c7f2": "provided",
                },
                Annotations: {
                    "olm.operatorGroup": "global-operators",
                    "olm.operatorNamespace": "operators",
                    "olm.targetNamespaces": "",
                },
                OwnerReferences: nil,
                Finalizers: nil,
                ClusterName: "",
                ManagedFields: nil,
            },
            Spec: {
                InstallStrategy: {
                    StrategyName: "deployment",
                    StrategySpec: {
                        DeploymentSpecs: [
                            {
                                Name: "dep5fn2j",
                                Spec: {
                                    Replicas: 1,
                                    Selector: {
                                        MatchLabels: {...: ...},
                                        MatchExpressions: nil,
                                    },
                                    Template: {
                                        ObjectMeta: {
                                            Name: ...,
                                            GenerateName: ...,
                                            Namespace: ...,
                                            SelfLink: ...,
                                            UID: ...,
                                            ResourceVersion: ...,
                                            Generation: ...,
                                            CreationTimestamp: ...,
                                            DeletionTimestamp: ...,
                                            DeletionGracePeriodSeconds: ...,
                                            Labels: ...,
                                            Annotations: ...,
                                            OwnerReferences: ...,
                                            Finalizers: ...,
                                            ClusterName: ...,
                                            ManagedFields: ...,
                                        },
                                        Spec: {
                                            Volumes: ...,
                                            InitContainers: ...,
                                            Containers: ...,
                                            EphemeralContainers: ...,
                                            RestartPolicy: ...,
                                            TerminationGracePeriodSeconds: ...,
                                            ActiveDeadlineSeconds: ...,
                                            DNSPolicy: ...,
                                            NodeSelector: ...,
                                            ServiceAccountName: ...,
                                            DeprecatedServiceAccount: ...,
                                            AutomountServiceAccountToken: ...,
                                            NodeName: ...,
                                            HostNetwork: ...,
                                            HostPID: ...,
                                            HostIPC: ...,
                                            ShareProcessNamespace: ...,
                                            SecurityContext: ...,
                                            ImagePullSecrets: ...,
                                            Hostname: ...,
                                            Subdomain: ...,
                                            Affinity: ...,
                                            SchedulerName: ...,
                                            Tolerations: ...,
                                            HostAliases: ...,
                                            PriorityClassName: ...,
                                            Priority: ...,
                                            DNSConfig: ...,
                                            ReadinessGates: ...,
                                            RuntimeClassName: ...,
                                            EnableServiceLinks: ...,
                                            PreemptionPolicy: ...,
                                            Overhead: ...,
                                            TopologySpreadConstraints: ...,
                                        },
                                    },
                                    Strategy: {Type: "", RollingUpdate: nil},
                                    MinReadySeconds: 0,
                                    RevisionHistoryLimit: nil,
                                    Paused: false,
                                    ProgressDeadlineSeconds: nil,
                                },
                                Label: nil,
                            },
                        ],
                        Permissions: nil,
                        ClusterPermissions: nil,
                    },
                },
                Version: {
                    Version: {Major: 0, Minor: 1, Patch: 0, Pre: nil, Build: nil},
                },
                Maturity: "",
                CustomResourceDefinitions: {
                    Owned: [
                        {
                            Name: "insjp8jz.cluster.com",
                            Version: "v1alpha1",
                            Kind: "insjp8jz",
                            DisplayName: "insjp8jz.cluster.com",
                            Description: "insjp8jz.cluster.com",
                            Resources: nil,
                            StatusDescriptors: nil,
                            SpecDescriptors: nil,
                            ActionDescriptor: nil,
                        },
                    ],
                    Required: nil,
                },
                APIServiceDefinitions: {Owned: nil, Required: nil},
                WebhookDefinitions: nil,
                NativeAPIs: nil,
                MinKubeVersion: "0.0.0",
                DisplayName: "",
                Description: "",
                Keywords: nil,
                Maintainers: nil,
                Provider: {Name: "", URL: ""},
                Links: nil,
                Icon: nil,
                InstallModes: [
                    {Type: "OwnNamespace", Supported: true},
                    {
                        Type: "SingleNamespace",
                        Supported: true,
                    },
                    {
                        Type: "MultiNamespace",
                        Supported: true,
                    },
                    {
                        Type: "AllNamespaces",
                        Supported: true,
                    },
                ],
                Replaces: "",
                Labels: nil,
                Annotations: nil,
                Selector: nil,
            },
            Status: {
                Phase: "Succeeded",
                Message: "install strategy completed with no errors",
                Reason: "InstallSucceeded",
                LastUpdateTime: {
                    Time: 2020-07-31T14:18:11Z,
                },
                LastTransitionTime: {
                    Time: 2020-07-31T14:18:11Z,
                },
                Conditions: [
                    {
                        Phase: "Pending",
                        Message: "requirements not yet checked",
                        Reason: "RequirementsUnknown",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:18:05Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:18:05Z,
                        },
                    },
                    {
                        Phase: "Pending",
                        Message: "one or more requirements couldn't be found",
                        Reason: "RequirementsNotMet",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:18:05Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:18:05Z,
                        },
                    },
                    {
                        Phase: "InstallReady",
                        Message: "all requirements found, attempting install",
                        Reason: "AllRequirementsMet",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:18:07Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:18:07Z,
                        },
                    },
                    {
                        Phase: "Installing",
                        Message: "waiting for install components to report healthy",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:18:08Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:18:08Z,
                        },
                    },
                    {
                        Phase: "Installing",
                        Message: "installing: waiting for deployment dep5fn2j to become ready: Waiting for rollout to finish: 0 of 1 updated replicas are available...\n",
                        Reason: "InstallWaiting",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:18:09Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:18:08Z,
                        },
                    },
                    {
                        Phase: "Succeeded",
                        Message: "install strategy completed with no errors",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:18:11Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:18:11Z,
                        },
                    },
                ],
                RequirementStatus: [
                    {
                        Group: "operators.coreos.com",
                        Version: "v1alpha1",
                        Kind: "ClusterServiceVersion",
                        Name: "csv-e",
                        Status: "Present",
                        Message: "CSV minKubeVersion (0.0.0) less than server version (v1.17.0)",
                        UUID: "",
                        Dependents: nil,
                    },
                    {
                        Group: "apiextensions.k8s.io",
                        Version: "v1",
                        Kind: "CustomResourceDefinition",
                        Name: "insjp8jz.cluster.com",
                        Status: "Present",
                        Message: "CRD is present and Established condition is true",
                        UUID: "d778e80d-7611-456e-98ae-9a998a9f4c91",
                        Dependents: nil,
                    },
                ],
                CertsLastUpdated: nil,
                CertsRotateAt: nil,
            },
        },
    ]
to be empty
/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/util_test.go:496

meandurationsec: 76.536484

classname: End-to-end
name: 'Install Plan with CSVs across multiple catalog sources'
counts: 1
details:

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:44
Resource does not match expected value:   &v1alpha1.InstallPlan{
  	TypeMeta: {},
  	ObjectMeta: v1.ObjectMeta{
  		... // 3 identical fields
  		SelfLink:                   "/apis/operators.coreos.com/v1alpha1/namespaces/operators/install"...,
  		UID:                        "c8e803c1-c332-4596-8fd8-30ae8d05a307",
- 		ResourceVersion:            "13655",
+ 		ResourceVersion:            "13695",
  		Generation:                 1,
  		CreationTimestamp:          {Time: s"2020-07-31 14:23:11 +0000 UTC"},
  		DeletionTimestamp:          nil,
  		DeletionGracePeriodSeconds: nil,
  		Labels: map[string]string{
  			"operators.coreos.com/nginx-x5jrk.operators":    "",
+ 			"operators.coreos.com/nginxdep-qghcw.operators": "",
  		},
  		Annotations:     nil,
  		OwnerReferences: {{APIVersion: "operators.coreos.com/v1alpha1", Kind: "Subscription", Name: "sub-nginx-fdc86", UID: "3a3f1eab-8686-417f-ba4f-4f7c13773aa3", ...}},
  		... // 3 identical fields
  	},
  	Spec:   {ClusterServiceVersionNames: {"nginxdep-qghcw-stable", "nginx-x5jrk-stable"}, Approval: "Automatic", Approved: true, Generation: 1},
  	Status: {Phase: "Complete", Conditions: {{Type: "Installed", Status: "True", LastUpdateTime: s"2020-07-31 14:23:12 +0000 UTC", LastTransitionTime: s"2020-07-31 14:23:12 +0000 UTC", ...}}, CatalogSources: {"mock-ocs-dependent-s4vb7", "mock-ocs-main-lhcr5"}, Plan: {&{Resolving: "nginxdep-qghcw-stable", Resource: {CatalogSource: "mock-ocs-dependent-s4vb7", CatalogSourceNamespace: "operators", Version: "v1alpha1", Kind: "ClusterServiceVersion", ...}, Status: "Present"}, &{Resolving: "nginx-x5jrk-stable", Resource: {CatalogSource: "mock-ocs-main-lhcr5", CatalogSourceNamespace: "operators", Version: "v1alpha1", Kind: "ClusterServiceVersion", ...}, Status: "Present"}, &{Resolving: "nginxdep-qghcw-stable", Resource: {CatalogSource: "mock-ocs-dependent-s4vb7", CatalogSourceNamespace: "operators", Group: "apiextensions.k8s.io", Version: "v1beta1", ...}, Status: "Present"}, &{Resolving: "nginxdep-qghcw-stable", Resource: {CatalogSource: "mock-ocs-dependent-s4vb7", CatalogSourceNamespace: "operators", Group: "operators.coreos.com", Version: "v1alpha1", ...}, Status: "Present"}}, ...},
  }

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:2699

meandurationsec: 72.172545
skippedtests:

classname: End-to-end
name: 'Subscriptions create required objects from Catalogs Given a Namespace
when a CatalogSource is created with a bundle that contains prometheus objects
creating a subscription using the CatalogSource should have created the expected
prometheus objects'
counts: 1
details: []
meandurationsec: 43.206759
classname: End-to-end
name: 'Subscription updates existing install plan'
counts: 1
details: []
meandurationsec: 0.014146
classname: End-to-end
name: 'Catalog image update'
counts: 1
details: []
meandurationsec: 0.042667
classname: End-to-end
name: 'Subscriptions create required objects from Catalogs Given a Namespace
when a CatalogSource is created with a bundle that contains prometheus objects
creating a subscription using the CatalogSource should install the operator
successfully'
counts: 1
details: []
meandurationsec: 21.110198

openshift-bot · 2020-07-31T14:54:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

Bowenislandsong · 2020-07-31T15:34:22Z

This PR failed tests for 1 times with 5 individual failed tests and 4 skipped tests. A test is considered flaky if failed on multiple commits.

totaltestcount: 1
flaketestcount: 5
skippedtestcount: 4
flaketests:

classname: End-to-end
name: 'User defined service account with permission'
counts: 3
details:
- count: 3
  error: "\n\n/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/user_defined_sa_test.go:82\n\n\tError
  Trace:\tuser_defined_sa_test.go:134\n\t \t\t\t\trunner.go:113\n\t
  \ \t\t\t\trunner.go:64\n\t \t\t\t\tit_node.go:26\n\t
  \ \t\t\t\tspec.go:215\n\t \t\t\t\tspec.go:138\n\t
  \ \t\t\t\tspec_runner.go:200\n\t \t\t\t\tspec_runner.go:170\n\t
  \ \t\t\t\tspec_runner.go:66\n\t \t\t\t\tsuite.go:62\n\t
  \ \t\t\t\tginkgo_dsl.go:226\n\t \t\t\t\tginkgo_dsl.go:214\n\t
  \ \t\t\t\te2e_test.go:54\n\tError: \tNot equal: \n\t \texpected:
  "Created"\n\t \tactual : "Present"\n\t \t\n\t
  \ \tDiff:\n\t \t--- Expected\n\t \t+++
  Actual\n\t \t@@ -1,2 +1,2 @@\n\t \t-(v1alpha1.StepStatus)
  (len=7) "Created"\n\t \t+(v1alpha1.StepStatus) (len=7) "Present"\n\t
  \ \t \n\n/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/user_defined_sa_test.go:134"
  meandurationsec: 26.370992333333334

classname: End-to-end
name: 'Catalog config map update triggers registry pod rollout'
counts: 2
details:

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/catalog_e2e_test.go:34
Timed out after 60.001s.
failed to await deletion of test csvs
Expected
    <[]v1alpha1.ClusterServiceVersion | len:1, cap:1>: [
        {
            TypeMeta: {
                Kind: "ClusterServiceVersion",
                APIVersion: "operators.coreos.com/v1alpha1",
            },
            ObjectMeta: {
                Name: "nginx-9lxvk-stable",
                GenerateName: "",
                Namespace: "operators",
                SelfLink: "/apis/operators.coreos.com/v1alpha1/namespaces/operators/clusterserviceversions/nginx-9lxvk-stable",
                UID: "651500f4-92b3-4103-af81-5cfe053a4708",
                ResourceVersion: "20115",
                Generation: 1,
                CreationTimestamp: {
                    Time: 2020-07-31T15:16:09Z,
                },
                DeletionTimestamp: nil,
                DeletionGracePeriodSeconds: nil,
                Labels: {
                    "olm.api.af1ebb13af49427b": "required",
                },
                Annotations: {
                    "olm.targetNamespaces": "",
                    "olm.operatorGroup": "global-operators",
                    "olm.operatorNamespace": "operators",
                },
                OwnerReferences: nil,
                Finalizers: nil,
                ClusterName: "",
                ManagedFields: nil,
            },
            Spec: {
                InstallStrategy: {
                    StrategyName: "deployment",
                    StrategySpec: {
                        DeploymentSpecs: [
                            {
                                Name: "depgqmmp",
                                Spec: {
                                    Replicas: 1,
                                    Selector: {
                                        MatchLabels: {...: ...},
                                        MatchExpressions: nil,
                                    },
                                    Template: {
                                        ObjectMeta: {
                                            Name: ...,
                                            GenerateName: ...,
                                            Namespace: ...,
                                            SelfLink: ...,
                                            UID: ...,
                                            ResourceVersion: ...,
                                            Generation: ...,
                                            CreationTimestamp: ...,
                                            DeletionTimestamp: ...,
                                            DeletionGracePeriodSeconds: ...,
                                            Labels: ...,
                                            Annotations: ...,
                                            OwnerReferences: ...,
                                            Finalizers: ...,
                                            ClusterName: ...,
                                            ManagedFields: ...,
                                        },
                                        Spec: {
                                            Volumes: ...,
                                            InitContainers: ...,
                                            Containers: ...,
                                            EphemeralContainers: ...,
                                            RestartPolicy: ...,
                                            TerminationGracePeriodSeconds: ...,
                                            ActiveDeadlineSeconds: ...,
                                            DNSPolicy: ...,
                                            NodeSelector: ...,
                                            ServiceAccountName: ...,
                                            DeprecatedServiceAccount: ...,
                                            AutomountServiceAccountToken: ...,
                                            NodeName: ...,
                                            HostNetwork: ...,
                                            HostPID: ...,
                                            HostIPC: ...,
                                            ShareProcessNamespace: ...,
                                            SecurityContext: ...,
                                            ImagePullSecrets: ...,
                                            Hostname: ...,
                                            Subdomain: ...,
                                            Affinity: ...,
                                            SchedulerName: ...,
                                            Tolerations: ...,
                                            HostAliases: ...,
                                            PriorityClassName: ...,
                                            Priority: ...,
                                            DNSConfig: ...,
                                            ReadinessGates: ...,
                                            RuntimeClassName: ...,
                                            EnableServiceLinks: ...,
                                            PreemptionPolicy: ...,
                                            Overhead: ...,
                                            TopologySpreadConstraints: ...,
                                        },
                                    },
                                    Strategy: {Type: "", RollingUpdate: nil},
                                    MinReadySeconds: 0,
                                    RevisionHistoryLimit: nil,
                                    Paused: false,
                                    ProgressDeadlineSeconds: nil,
                                },
                                Label: nil,
                            },
                        ],
                        Permissions: nil,
                        ClusterPermissions: nil,
                    },
                },
                Version: {
                    Version: {Major: 0, Minor: 1, Patch: 0, Pre: nil, Build: nil},
                },
                Maturity: "",
                CustomResourceDefinitions: {
                    Owned: nil,
                    Required: [
                        {
                            Name: "ins-xj8tp.cluster.com",
                            Version: "v1alpha1",
                            Kind: "ins-xj8tp",
                            DisplayName: "ins-xj8tp.cluster.com",
                            Description: "ins-xj8tp.cluster.com",
                            Resources: nil,
                            StatusDescriptors: nil,
                            SpecDescriptors: nil,
                            ActionDescriptor: nil,
                        },
                    ],
                },
                APIServiceDefinitions: {Owned: nil, Required: nil},
                WebhookDefinitions: nil,
                NativeAPIs: nil,
                MinKubeVersion: "0.0.0",
                DisplayName: "",
                Description: "",
                Keywords: nil,
                Maintainers: nil,
                Provider: {Name: "", URL: ""},
                Links: nil,
                Icon: nil,
                InstallModes: [
                    {Type: "OwnNamespace", Supported: true},
                    {
                        Type: "SingleNamespace",
                        Supported: true,
                    },
                    {
                        Type: "MultiNamespace",
                        Supported: true,
                    },
                    {
                        Type: "AllNamespaces",
                        Supported: true,
                    },
                ],
                Replaces: "",
                Labels: nil,
                Annotations: nil,
                Selector: nil,
            },
            Status: {
                Phase: "Pending",
                Message: "one or more requirements couldn't be found",
                Reason: "RequirementsNotMet",
                LastUpdateTime: {
                    Time: 2020-07-31T15:16:10Z,
                },
                LastTransitionTime: {
                    Time: 2020-07-31T15:16:09Z,
                },
                Conditions: [
                    {
                        Phase: "Pending",
                        Message: "requirements not yet checked",
                        Reason: "RequirementsUnknown",
                        LastUpdateTime: {
                            Time: 2020-07-31T15:16:09Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T15:16:09Z,
                        },
                    },
                    {
                        Phase: "Pending",
                        Message: "one or more requirements couldn't be found",
                        Reason: "RequirementsNotMet",
                        LastUpdateTime: {
                            Time: 2020-07-31T15:16:10Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T15:16:09Z,
                        },
                    },
                ],
                RequirementStatus: [
                    {
                        Group: "operators.coreos.com",
                        Version: "v1alpha1",
                        Kind: "ClusterServiceVersion",
                        Name: "nginx-9lxvk-stable",
                        Status: "Present",
                        Message: "CSV minKubeVersion (0.0.0) less than server version (v1.17.0)",
                        UUID: "",
                        Dependents: nil,
                    },
                    {
                        Group: "apiextensions.k8s.io",
                        Version: "v1",
                        Kind: "CustomResourceDefinition",
                        Name: "ins-xj8tp.cluster.com",
                        Status: "NotPresent",
                        Message: "CRD is not present",
                        UUID: "",
                        Dependents: nil,
                    },
                ],
                CertsLastUpdated: nil,
                CertsRotateAt: nil,
            },
        },
    ]
to be empty
/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/util_test.go:496

meandurationsec: 225.15009350000003

classname: End-to-end
name: 'Subscription creation with dependencies'
counts: 1
details:

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/subscription_e2e_test.go:46
Timed out after 60.001s.
failed to await deletion of test csvs
Expected
    <[]v1alpha1.ClusterServiceVersion | len:1, cap:1>: [
        {
            TypeMeta: {
                Kind: "ClusterServiceVersion",
                APIVersion: "operators.coreos.com/v1alpha1",
            },
            ObjectMeta: {
                Name: "nginx-dependency",
                GenerateName: "",
                Namespace: "operators",
                SelfLink: "/apis/operators.coreos.com/v1alpha1/namespaces/operators/clusterserviceversions/nginx-dependency",
                UID: "54d75278-f55c-4643-b0f6-5bdaad082ea8",
                ResourceVersion: "6546",
                Generation: 1,
                CreationTimestamp: {
                    Time: 2020-07-31T14:54:58Z,
                },
                DeletionTimestamp: nil,
                DeletionGracePeriodSeconds: nil,
                Labels: {
                    "olm.api.22830face12bc66d": "provided",
                },
                Annotations: {
                    "olm.operatorNamespace": "operators",
                    "olm.targetNamespaces": "",
                    "olm.operatorGroup": "global-operators",
                },
                OwnerReferences: nil,
                Finalizers: nil,
                ClusterName: "",
                ManagedFields: nil,
            },
            Spec: {
                InstallStrategy: {
                    StrategyName: "deployment",
                    StrategySpec: {
                        DeploymentSpecs: [
                            {
                                Name: "podconfig-dep-8l6nx",
                                Spec: {
                                    Replicas: 1,
                                    Selector: {
                                        MatchLabels: {...: ...},
                                        MatchExpressions: nil,
                                    },
                                    Template: {
                                        ObjectMeta: {
                                            Name: ...,
                                            GenerateName: ...,
                                            Namespace: ...,
                                            SelfLink: ...,
                                            UID: ...,
                                            ResourceVersion: ...,
                                            Generation: ...,
                                            CreationTimestamp: ...,
                                            DeletionTimestamp: ...,
                                            DeletionGracePeriodSeconds: ...,
                                            Labels: ...,
                                            Annotations: ...,
                                            OwnerReferences: ...,
                                            Finalizers: ...,
                                            ClusterName: ...,
                                            ManagedFields: ...,
                                        },
                                        Spec: {
                                            Volumes: ...,
                                            InitContainers: ...,
                                            Containers: ...,
                                            EphemeralContainers: ...,
                                            RestartPolicy: ...,
                                            TerminationGracePeriodSeconds: ...,
                                            ActiveDeadlineSeconds: ...,
                                            DNSPolicy: ...,
                                            NodeSelector: ...,
                                            ServiceAccountName: ...,
                                            DeprecatedServiceAccount: ...,
                                            AutomountServiceAccountToken: ...,
                                            NodeName: ...,
                                            HostNetwork: ...,
                                            HostPID: ...,
                                            HostIPC: ...,
                                            ShareProcessNamespace: ...,
                                            SecurityContext: ...,
                                            ImagePullSecrets: ...,
                                            Hostname: ...,
                                            Subdomain: ...,
                                            Affinity: ...,
                                            SchedulerName: ...,
                                            Tolerations: ...,
                                            HostAliases: ...,
                                            PriorityClassName: ...,
                                            Priority: ...,
                                            DNSConfig: ...,
                                            ReadinessGates: ...,
                                            RuntimeClassName: ...,
                                            EnableServiceLinks: ...,
                                            PreemptionPolicy: ...,
                                            Overhead: ...,
                                            TopologySpreadConstraints: ...,
                                        },
                                    },
                                    Strategy: {Type: "", RollingUpdate: nil},
                                    MinReadySeconds: 0,
                                    RevisionHistoryLimit: nil,
                                    Paused: false,
                                    ProgressDeadlineSeconds: nil,
                                },
                                Label: nil,
                            },
                        ],
                        Permissions: [
                            {
                                ServiceAccountName: "nginx-sa-qcpq7",
                                Rules: [
                                    {Verbs: [...], APIGroups: [...], Resources: [...], ResourceNames: nil, NonResourceURLs: nil},
                                ],
                            },
                        ],
                        ClusterPermissions: nil,
                    },
                },
                Version: {
                    Version: {Major: 0, Minor: 1, Patch: 0, Pre: nil, Build: nil},
                },
                Maturity: "",
                CustomResourceDefinitions: {
                    Owned: [
                        {
                            Name: "insqhsrm.cluster.com",
                            Version: "v1alpha1",
                            Kind: "insqhsrm",
                            DisplayName: "insqhsrm.cluster.com",
                            Description: "insqhsrm.cluster.com",
                            Resources: nil,
                            StatusDescriptors: nil,
                            SpecDescriptors: nil,
                            ActionDescriptor: nil,
                        },
                    ],
                    Required: nil,
                },
                APIServiceDefinitions: {Owned: nil, Required: nil},
                WebhookDefinitions: nil,
                NativeAPIs: nil,
                MinKubeVersion: "0.0.0",
                DisplayName: "",
                Description: "",
                Keywords: nil,
                Maintainers: nil,
                Provider: {Name: "", URL: ""},
                Links: nil,
                Icon: nil,
                InstallModes: [
                    {Type: "OwnNamespace", Supported: true},
                    {
                        Type: "SingleNamespace",
                        Supported: true,
                    },
                    {
                        Type: "MultiNamespace",
                        Supported: true,
                    },
                    {
                        Type: "AllNamespaces",
                        Supported: true,
                    },
                ],
                Replaces: "",
                Labels: nil,
                Annotations: nil,
                Selector: nil,
            },
            Status: {
                Phase: "Pending",
                Message: "one or more requirements couldn't be found",
                Reason: "RequirementsNotMet",
                LastUpdateTime: {
                    Time: 2020-07-31T14:55:01Z,
                },
                LastTransitionTime: {
                    Time: 2020-07-31T14:55:01Z,
                },
                Conditions: [
                    {
                        Phase: "Pending",
                        Message: "requirements not yet checked",
                        Reason: "RequirementsUnknown",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:54:58Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:54:58Z,
                        },
                    },
                    {
                        Phase: "InstallReady",
                        Message: "all requirements found, attempting install",
                        Reason: "AllRequirementsMet",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:54:59Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:54:59Z,
                        },
                    },
                    {
                        Phase: "Installing",
                        Message: "waiting for install components to report healthy",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:55:00Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:55:00Z,
                        },
                    },
                    {
                        Phase: "Succeeded",
                        Message: "install strategy completed with no errors",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:55:00Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:55:00Z,
                        },
                    },
                    {
                        Phase: "Failed",
                        Message: "requirements no longer met",
                        Reason: "RequirementsNotMet",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:55:01Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:55:01Z,
                        },
                    },
                    {
                        Phase: "Pending",
                        Message: "requirements not met",
                        Reason: "RequirementsNotMet",
                        LastUpdateTime: {
                            Time: 2020-07-31T14:55:01Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T14:55:01Z,
                        },
                    },
                ],
                RequirementStatus: [
                    {
                        Group: "operators.coreos.com",
                        Version: "v1alpha1",
                        Kind: "ClusterServiceVersion",
                        Name: "nginx-dependency",
                        Status: "Present",
                        Message: "CSV minKubeVersion (0.0.0) less than server version (v1.17.0)",
                        UUID: "",
                        Dependents: nil,
                    },
                    {
                        Group: "apiextensions.k8s.io",
                        Version: "v1",
                        Kind: "CustomResourceDefinition",
                        Name: "insqhsrm.cluster.com",
                        Status: "Present",
                        Message: "CRD is present and Established condition is true",
                        UUID: "6e351fcd-8621-4224-b5f8-799163f64c70",
                        Dependents: nil,
                    },
                    {
                        Group: "",
                        Version: "v1",
                        Kind: "ServiceAccount",
                        Name: "nginx-sa-qcpq7",
                        Status: "NotPresent",
                        Message: "Service account does not exist",
                        UUID: "",
                        Dependents: nil,
                    },
                ],
                CertsLastUpdated: nil,
                CertsRotateAt: nil,
            },
        },
    ]
to be empty
/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/util_test.go:496

meandurationsec: 310.283499

classname: End-to-end
name: 'Install Plan with CSVs across multiple catalog sources'
counts: 1
details:

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:44
Resource does not match expected value:   &v1alpha1.InstallPlan{
  	TypeMeta: {},
  	ObjectMeta: v1.ObjectMeta{
  		... // 3 identical fields
  		SelfLink:                   "/apis/operators.coreos.com/v1alpha1/namespaces/operators/install"...,
  		UID:                        "50fe684f-bb27-466b-a7de-7b683491b761",
- 		ResourceVersion:            "11247",
+ 		ResourceVersion:            "11257",
  		Generation:                 1,
  		CreationTimestamp:          {Time: s"2020-07-31 15:05:05 +0000 UTC"},
  		DeletionTimestamp:          nil,
  		DeletionGracePeriodSeconds: nil,
  		Labels: map[string]string{
  			"operators.coreos.com/nginx-kzqt6.operators":    "",
+ 			"operators.coreos.com/nginxdep-ksdtf.operators": "",
  		},
  		Annotations:     nil,
  		OwnerReferences: {{APIVersion: "operators.coreos.com/v1alpha1", Kind: "Subscription", Name: "sub-nginx-f2lqm", UID: "c4edec7d-2703-47f7-9b37-d5d535d1ab26", ...}},
  		... // 3 identical fields
  	},
  	Spec:   {ClusterServiceVersionNames: {"nginxdep-ksdtf-stable", "nginx-kzqt6-stable"}, Approval: "Automatic", Approved: true, Generation: 1},
  	Status: {Phase: "Complete", Conditions: {{Type: "Installed", Status: "True", LastUpdateTime: s"2020-07-31 15:05:08 +0000 UTC", LastTransitionTime: s"2020-07-31 15:05:08 +0000 UTC", ...}}, CatalogSources: {"mock-ocs-dependent-x8jqn", "mock-ocs-main-smxvt"}, Plan: {&{Resolving: "nginxdep-ksdtf-stable", Resource: {CatalogSource: "mock-ocs-dependent-x8jqn", CatalogSourceNamespace: "operators", Version: "v1alpha1", Kind: "ClusterServiceVersion", ...}, Status: "Present"}, &{Resolving: "nginx-kzqt6-stable", Resource: {CatalogSource: "mock-ocs-main-smxvt", CatalogSourceNamespace: "operators", Version: "v1alpha1", Kind: "ClusterServiceVersion", ...}, Status: "Present"}, &{Resolving: "nginxdep-ksdtf-stable", Resource: {CatalogSource: "mock-ocs-dependent-x8jqn", CatalogSourceNamespace: "operators", Group: "apiextensions.k8s.io", Version: "v1beta1", ...}, Status: "Present"}, &{Resolving: "nginxdep-ksdtf-stable", Resource: {CatalogSource: "mock-ocs-dependent-x8jqn", CatalogSourceNamespace: "operators", Group: "operators.coreos.com", Version: "v1alpha1", ...}, Status: "Present"}}, ...},
  }

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:2699

meandurationsec: 61.417355

classname: End-to-end
name: 'Installing bundles with new object types when a bundle with a pdb, priorityclass,
and VPA object is installed should create the additional bundle objects'
counts: 1
details:

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/bundle_e2e_test.go:124
Timed out after 60.000s.
expected no error getting pdb object associated with CSV
Expected success, but got an error:
    <*errors.StatusError | 0xc000a2c3c0>: {
        ErrStatus: {
            TypeMeta: {Kind: "", APIVersion: ""},
            ListMeta: {
                SelfLink: "",
                ResourceVersion: "",
                Continue: "",
                RemainingItemCount: nil,
            },
            Status: "Failure",
            Message: "poddisruptionbudgets.policy \"busybox-pdb\" not found",
            Reason: "NotFound",
            Details: {
                Name: "busybox-pdb",
                Group: "policy",
                Kind: "poddisruptionbudgets",
                UID: "",
                Causes: nil,
                RetryAfterSeconds: 0,
            },
            Code: 404,
        },
    }
    poddisruptionbudgets.policy "busybox-pdb" not found
/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/bundle_e2e_test.go:144

meandurationsec: 80.962454
skippedtests:

classname: End-to-end
name: 'Catalog image update'
counts: 1
details: []
meandurationsec: 0.051572
classname: End-to-end
name: 'Subscriptions create required objects from Catalogs Given a Namespace
when a CatalogSource is created with a bundle that contains prometheus objects
creating a subscription using the CatalogSource should install the operator
successfully'
counts: 1
details: []
meandurationsec: 26.604794
classname: End-to-end
name: 'Subscription updates existing install plan'
counts: 1
details: []
meandurationsec: 0.07251
classname: End-to-end
name: 'Subscriptions create required objects from Catalogs Given a Namespace
when a CatalogSource is created with a bundle that contains prometheus objects
creating a subscription using the CatalogSource should have created the expected
prometheus objects'
counts: 1
details: []
meandurationsec: 15.157563

openshift-bot · 2020-07-31T16:06:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

njhale · 2020-07-31T18:53:16Z

/test e2e-aws-olm

njhale · 2020-07-31T19:34:28Z

/hold

seeing this test fail locally as well, investigating

Allow a user defined SA e2e test to pass if ultimate step status is Present as well as Created. Both states are roughly equivalent for the purposes of the test. The state most likely hits Present instead of Created in some cases when the resourceVersion of the InstallPlan changes between the start and end of plan execution, causing the next reconciliation to think the resources already existed. This change can be reverted if we use a status patch in place of an update.

openshift-bot · 2020-08-01T03:48:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-01T10:18:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-01T10:31:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-01T12:15:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-01T13:07:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-01T14:51:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-01T17:14:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-01T18:58:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-01T19:50:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-01T23:44:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-02T02:20:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-02T07:32:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-02T08:37:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-02T09:55:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-02T12:57:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-03T01:57:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-03T02:10:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-03T05:38:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-03T08:14:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-03T10:49:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-03T11:02:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-03T13:25:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

njhale · 2020-08-03T13:58:38Z

/hold

Checking this out locally.

njhale · 2020-08-03T17:50:42Z

Fix merged, let's try this again.

/hold cancel
/test e2e-aws-olm

openshift-bot · 2020-08-03T21:40:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-03T21:52:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot requested review from anik120 and ecordell July 21, 2020 14:31

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2020

njhale force-pushed the ext-adopt branch from b671494 to 7fabbe0 Compare July 21, 2020 17:40

ecordell reviewed Jul 27, 2020

View reviewed changes

njhale force-pushed the ext-adopt branch 2 times, most recently from 2660822 to 2c0d0fc Compare July 30, 2020 18:43

ecordell reviewed Jul 31, 2020

View reviewed changes

feat(operator): adopt referenced installplans

0950140

Adopt InstallPlans to the Operator(s) represented by the Subscriptions that reference them. This means that InstallPlans are components of the operators they install.

njhale force-pushed the ext-adopt branch from 2c0d0fc to 0950140 Compare July 31, 2020 13:51

openshift-ci-robot assigned ecordell Jul 31, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2020

openshift-merge-robot merged commit 5e5b11f into operator-framework:master Aug 4, 2020

njhale deleted the ext-adopt branch July 23, 2021 02:44

feat(operator): adopt referenced installplans #1661

feat(operator): adopt referenced installplans #1661

Conversation

njhale commented Jul 21, 2020

openshift-ci-robot commented Jul 21, 2020

njhale commented Jul 21, 2020

exdx commented Jul 22, 2020

njhale commented Jul 23, 2020

njhale commented Jul 23, 2020

ecordell Jul 27, 2020

Choose a reason for hiding this comment

njhale Jul 27, 2020

Choose a reason for hiding this comment

njhale commented Jul 28, 2020

njhale commented Jul 30, 2020

njhale commented Jul 30, 2020

njhale commented Jul 31, 2020

ecordell Jul 31, 2020

Choose a reason for hiding this comment

ecordell commented Jul 31, 2020

Bowenislandsong commented Jul 31, 2020

openshift-bot commented Jul 31, 2020

Bowenislandsong commented Jul 31, 2020

openshift-bot commented Jul 31, 2020

njhale commented Jul 31, 2020

njhale commented Jul 31, 2020

openshift-bot commented Aug 1, 2020

openshift-bot commented Aug 1, 2020

openshift-bot commented Aug 1, 2020

openshift-bot commented Aug 1, 2020

openshift-bot commented Aug 1, 2020

openshift-bot commented Aug 1, 2020

openshift-bot commented Aug 1, 2020

openshift-bot commented Aug 1, 2020

openshift-bot commented Aug 1, 2020

openshift-bot commented Aug 1, 2020

openshift-bot commented Aug 2, 2020

openshift-bot commented Aug 2, 2020

openshift-bot commented Aug 2, 2020

openshift-bot commented Aug 2, 2020

openshift-bot commented Aug 2, 2020

openshift-bot commented Aug 3, 2020

openshift-bot commented Aug 3, 2020

openshift-bot commented Aug 3, 2020

openshift-bot commented Aug 3, 2020

openshift-bot commented Aug 3, 2020

openshift-bot commented Aug 3, 2020

openshift-bot commented Aug 3, 2020

njhale commented Aug 3, 2020

njhale commented Aug 3, 2020

openshift-bot commented Aug 3, 2020

openshift-bot commented Aug 3, 2020