Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded toleration from catalog source pod #1680

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Remove unneeded toleration from catalog source pod #1680

merged 1 commit into from
Jul 31, 2020

Conversation

kramvan1
Copy link
Contributor

Description of the change:

This toleration will try to go to any node, but does not handle
nodes that are not schedulable or pods that have been evicted from a
node.

Motivation for the change:

I don't see a good reason for using this toleration, it will only cause issues with pod that are evicted and nodes that are not ready or schedulable.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs n/a
  • Commit messages sensible and descriptive

Closes #1677

@kramvan1
Remove unneeded toleration from catalog source pod
c1b899d 
This toleration will try to go to any node, but does not handle
nodes that are not schedulable or pods that have been evicted from a
node.

Fixes #1677
@openshift-ci-robot
Copy link
Collaborator

Hi @kramvan1. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 24, 2020
@ecordell
Copy link
Member

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 27, 2020
@ecordell
Copy link
Member

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, kramvan1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2020
@kramvan1
Copy link
Contributor Author

/retest

2 similar comments
@kramvan1
Copy link
Contributor Author

/retest

@kramvan1
Copy link
Contributor Author

/retest

@dinhxuanvu
Copy link
Member

/hold
Put a hold on this PR temporarily just to make way for another PR to get in first.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2020
@dinhxuanvu
Copy link
Member

Master is open. Remove the hold.
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2020
@kramvan1
Copy link
Contributor Author

@ecordell @dinhxuanvu I think this is ready to go now

@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@kramvan1
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 6e6f9c4 into operator-framework:master Jul 31, 2020
@flickerfly
Copy link
Contributor

Thanks @kramvan1!

@kramvan1 kramvan1 deleted the patch-1 branch August 3, 2020 14:26
@kramvan1 kramvan1 mentioned this pull request Aug 3, 2020
Closed
@benluddy
Copy link
Contributor

benluddy commented Aug 5, 2020

/cherry-pick release-4.5

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 5, 2020
Merged
@openshift-cherrypick-robot
Copy link

@benluddy: new pull request created: #1712

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exdx exdx Awaiting requested review from exdx

@njhale njhale Awaiting requested review from njhale

Assignees

@ecordell ecordell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Evicted CatalogSource pod causes failure
9 participants
@kramvan1 @openshift-ci-robot @ecordell @dinhxuanvu @openshift-bot @flickerfly @benluddy @openshift-cherrypick-robot @openshift-merge-robot