chore(clean): Remove legacy resolver #1696

ecordell · 2020-07-31T11:40:26Z

Description of the change:
Removes the legacy resolver entirely.

Motivation for the change:
Cleaning up

Reviewer Checklist

Implementation matches the proposed design, or proposal is updated to match implementation
Sufficient unit test coverage
Sufficient end-to-end test coverage
Docs updated or added to /docs
Commit messages sensible and descriptive

kevinrizza

/lgtm

openshift-ci-robot · 2020-07-31T12:04:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ecordell,kevinrizza]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Bowenislandsong · 2020-07-31T12:34:49Z

This PR failed tests for 1 times with 2 individual failed tests and 4 skipped tests. A test is considered flaky if failed on multiple commits.

totaltestcount: 1
flaketestcount: 2
skippedtestcount: 4
flaketests:

classname: End-to-end
name: 'Subscription creation with dependencies required and provided in different
versions of an operator in the same package'
counts: 3
details:

count: 3
error: |4-

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/subscription_e2e_test.go:46
Timed out after 60.001s.
failed to await deletion of test csvs
Expected
    <[]v1alpha1.ClusterServiceVersion | len:1, cap:1>: [
        {
            TypeMeta: {
                Kind: "ClusterServiceVersion",
                APIVersion: "operators.coreos.com/v1alpha1",
            },
            ObjectMeta: {
                Name: "csv-e",
                GenerateName: "",
                Namespace: "operators",
                SelfLink: "/apis/operators.coreos.com/v1alpha1/namespaces/operators/clusterserviceversions/csv-e",
                UID: "5ff1b535-60dd-414c-b918-49b9055b7c2d",
                ResourceVersion: "17739",
                Generation: 1,
                CreationTimestamp: {
                    Time: 2020-07-31T12:19:09Z,
                },
                DeletionTimestamp: nil,
                DeletionGracePeriodSeconds: nil,
                Labels: {
                    "olm.api.21dc62aa8c4359d9": "provided",
                },
                Annotations: {
                    "olm.operatorGroup": "global-operators",
                    "olm.operatorNamespace": "operators",
                    "olm.targetNamespaces": "",
                },
                OwnerReferences: nil,
                Finalizers: nil,
                ClusterName: "",
                ManagedFields: nil,
            },
            Spec: {
                InstallStrategy: {
                    StrategyName: "deployment",
                    StrategySpec: {
                        DeploymentSpecs: [
                            {
                                Name: "deppm4hz",
                                Spec: {
                                    Replicas: 1,
                                    Selector: {
                                        MatchLabels: {...: ...},
                                        MatchExpressions: nil,
                                    },
                                    Template: {
                                        ObjectMeta: {
                                            Name: ...,
                                            GenerateName: ...,
                                            Namespace: ...,
                                            SelfLink: ...,
                                            UID: ...,
                                            ResourceVersion: ...,
                                            Generation: ...,
                                            CreationTimestamp: ...,
                                            DeletionTimestamp: ...,
                                            DeletionGracePeriodSeconds: ...,
                                            Labels: ...,
                                            Annotations: ...,
                                            OwnerReferences: ...,
                                            Finalizers: ...,
                                            ClusterName: ...,
                                            ManagedFields: ...,
                                        },
                                        Spec: {
                                            Volumes: ...,
                                            InitContainers: ...,
                                            Containers: ...,
                                            EphemeralContainers: ...,
                                            RestartPolicy: ...,
                                            TerminationGracePeriodSeconds: ...,
                                            ActiveDeadlineSeconds: ...,
                                            DNSPolicy: ...,
                                            NodeSelector: ...,
                                            ServiceAccountName: ...,
                                            DeprecatedServiceAccount: ...,
                                            AutomountServiceAccountToken: ...,
                                            NodeName: ...,
                                            HostNetwork: ...,
                                            HostPID: ...,
                                            HostIPC: ...,
                                            ShareProcessNamespace: ...,
                                            SecurityContext: ...,
                                            ImagePullSecrets: ...,
                                            Hostname: ...,
                                            Subdomain: ...,
                                            Affinity: ...,
                                            SchedulerName: ...,
                                            Tolerations: ...,
                                            HostAliases: ...,
                                            PriorityClassName: ...,
                                            Priority: ...,
                                            DNSConfig: ...,
                                            ReadinessGates: ...,
                                            RuntimeClassName: ...,
                                            EnableServiceLinks: ...,
                                            PreemptionPolicy: ...,
                                            Overhead: ...,
                                            TopologySpreadConstraints: ...,
                                        },
                                    },
                                    Strategy: {Type: "", RollingUpdate: nil},
                                    MinReadySeconds: 0,
                                    RevisionHistoryLimit: nil,
                                    Paused: false,
                                    ProgressDeadlineSeconds: nil,
                                },
                                Label: nil,
                            },
                        ],
                        Permissions: nil,
                        ClusterPermissions: nil,
                    },
                },
                Version: {
                    Version: {Major: 0, Minor: 1, Patch: 0, Pre: nil, Build: nil},
                },
                Maturity: "",
                CustomResourceDefinitions: {
                    Owned: [
                        {
                            Name: "ins47m7p.cluster.com",
                            Version: "v1alpha1",
                            Kind: "ins47m7p",
                            DisplayName: "ins47m7p.cluster.com",
                            Description: "ins47m7p.cluster.com",
                            Resources: nil,
                            StatusDescriptors: nil,
                            SpecDescriptors: nil,
                            ActionDescriptor: nil,
                        },
                    ],
                    Required: nil,
                },
                APIServiceDefinitions: {Owned: nil, Required: nil},
                WebhookDefinitions: nil,
                NativeAPIs: nil,
                MinKubeVersion: "0.0.0",
                DisplayName: "",
                Description: "",
                Keywords: nil,
                Maintainers: nil,
                Provider: {Name: "", URL: ""},
                Links: nil,
                Icon: nil,
                InstallModes: [
                    {Type: "OwnNamespace", Supported: true},
                    {
                        Type: "SingleNamespace",
                        Supported: true,
                    },
                    {
                        Type: "MultiNamespace",
                        Supported: true,
                    },
                    {
                        Type: "AllNamespaces",
                        Supported: true,
                    },
                ],
                Replaces: "",
                Labels: nil,
                Annotations: nil,
                Selector: nil,
            },
            Status: {
                Phase: "Succeeded",
                Message: "install strategy completed with no errors",
                Reason: "InstallSucceeded",
                LastUpdateTime: {
                    Time: 2020-07-31T12:19:13Z,
                },
                LastTransitionTime: {
                    Time: 2020-07-31T12:19:13Z,
                },
                Conditions: [
                    {
                        Phase: "Pending",
                        Message: "requirements not yet checked",
                        Reason: "RequirementsUnknown",
                        LastUpdateTime: {
                            Time: 2020-07-31T12:19:10Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T12:19:10Z,
                        },
                    },
                    {
                        Phase: "InstallReady",
                        Message: "all requirements found, attempting install",
                        Reason: "AllRequirementsMet",
                        LastUpdateTime: {
                            Time: 2020-07-31T12:19:10Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T12:19:10Z,
                        },
                    },
                    {
                        Phase: "Installing",
                        Message: "waiting for install components to report healthy",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-07-31T12:19:10Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T12:19:10Z,
                        },
                    },
                    {
                        Phase: "Installing",
                        Message: "installing: waiting for deployment deppm4hz to become ready: Waiting for rollout to finish: 0 of 1 updated replicas are available...\n",
                        Reason: "InstallWaiting",
                        LastUpdateTime: {
                            Time: 2020-07-31T12:19:11Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T12:19:10Z,
                        },
                    },
                    {
                        Phase: "Succeeded",
                        Message: "install strategy completed with no errors",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-07-31T12:19:13Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-07-31T12:19:13Z,
                        },
                    },
                ],
                RequirementStatus: [
                    {
                        Group: "operators.coreos.com",
                        Version: "v1alpha1",
                        Kind: "ClusterServiceVersion",
                        Name: "csv-e",
                        Status: "Present",
                        Message: "CSV minKubeVersion (0.0.0) less than server version (v1.17.0)",
                        UUID: "",
                        Dependents: nil,
                    },
                    {
                        Group: "apiextensions.k8s.io",
                        Version: "v1",
                        Kind: "CustomResourceDefinition",
                        Name: "ins47m7p.cluster.com",
                        Status: "Present",
                        Message: "CRD is present and Established condition is true",
                        UUID: "d73bf4a0-d9cd-4be9-a618-5ce62ab403ff",
                        Dependents: nil,
                    },
                ],
                CertsLastUpdated: nil,
                CertsRotateAt: nil,
            },
        },
    ]
to be empty
/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/util_test.go:496

meandurationsec: 64.97627666666666

classname: End-to-end
name: 'CSV create requirements met API service'
counts: 1
details:

count: 1
error: |4-

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/csv_e2e_test.go:718

	Error Trace:	csv_e2e_test.go:872
	            				runner.go:113
	            				runner.go:64
	            				it_node.go:26
	            				spec.go:215
	            				spec.go:138
	            				spec_runner.go:200
	            				spec_runner.go:170
	            				spec_runner.go:66
	            				suite.go:62
	            				ginkgo_dsl.go:226
	            				ginkgo_dsl.go:214
	            				e2e_test.go:54
	Error:      	Received unexpected error:
	            	timed out waiting for the condition

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/stretchr/testify/require/require.go:1005

meandurationsec: 302.627966
skippedtests:

classname: End-to-end
name: 'Subscriptions create required objects from Catalogs Given a Namespace
when a CatalogSource is created with a bundle that contains prometheus objects
creating a subscription using the CatalogSource should install the operator
successfully'
counts: 1
details: []
meandurationsec: 22.299946
classname: End-to-end
name: 'Subscription updates existing install plan'
counts: 1
details: []
meandurationsec: 0.103699
classname: End-to-end
name: 'Catalog image update'
counts: 1
details: []
meandurationsec: 0.026561
classname: End-to-end
name: 'Subscriptions create required objects from Catalogs Given a Namespace
when a CatalogSource is created with a bundle that contains prometheus objects
creating a subscription using the CatalogSource should have created the expected
prometheus objects'
counts: 1
details: []
meandurationsec: 15.155147

openshift-bot · 2020-07-31T18:16:50Z

/retest