-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1869523: Fix nodeSelector subscription config override #1728
Bug 1869523: Fix nodeSelector subscription config override #1728
Conversation
@awgreene: This pull request references Bugzilla bug 1869523, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
d55b5b7
to
5dfa816
Compare
Problem: Empty nodeSelector overrides defined in the subscription are overwriting existing nodeSelectors in the CSV when empty / not set. Solution: Only override the nodeSelectors defined in the CSV when the provided nodeSelector list is not nil.
5dfa816
to
6ddb993
Compare
@awgreene: This pull request references Bugzilla bug 1869523, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, benluddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@awgreene: All pull requests linked via external trackers have merged: operator-framework/operator-lifecycle-manager#1728. Bugzilla bug 1869523 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Problem: Empty nodeSelector overrides defined in the subscription are
overwriting existing nodeSelectors in the CSV when empty / not set.
Solution: Only override the nodeSelectors defined in the CSV when the
provided nodeSelector list is not nil.