Bug 1870453: Should not compare the digest if cannot the new update pod's imageID

[jianzhangbjz]

Description of the change:

During the CatalogSource pods polling, OLM compare the digest of the update pod and the current served pods. But, OLM cannot get the imageID of the update pod once it's created. But, OLM still compare the digest, it leads to unnecessary updates operations. As follows:

 330 time="2020-08-19T05:28:57Z" level=warning msg="pod status unknown" CatalogSource=qe-app-registry-v5xz4
 331 time="2020-08-19T05:28:57Z" level=info msg="ImageID " CatalogSource=qe-app-registry-v5xz4
 332 time="2020-08-19T05:28:57Z" level=info msg="Update Pod ImageID " CatalogSource=qe-app-registry-v5xz4

Motivation for the change:
When the imageID of the update pod is empty, don't run the updates operations.

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

[openshift-ci-robot]

Hi @jianzhangbjz. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jianzhangbjz]

/assign @ankitathomas @njhale

[jianzhangbjz]

/assign @ankitathomas @njhale

[dinhxuanvu]

/ok-to-test

[dinhxuanvu]

@exdx Dan, this PR impacts your on-going polling PR. May want to see if we can consolidate the effort to avoid potential code conflict here.

[exdx]

/hold
This will be integrated with ongoing catalog polling bugfixes and should not be merged as-is

[exdx]

@jianzhangbjz thanks for your contribution. we are doing some refactoring in this space, take a look at #1733 which is also implementing the same bugfix but in the newer codepath. i would like to add an e2e test to this PR, which is something we can collaborate on and could also use your review.

[jianzhangbjz]

@exdx Thanks for your explanation! I get it, feel free to do any operations on this PR, thank you!

[openshift-ci-robot]

@jianzhangbjz: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp-upgrade	f492ef2	link	/test e2e-gcp-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jianzhangbjz]

/retitle Bug 1870453: Should not compare the digest if cannot the new update pod's imageID

[openshift-ci-robot]

@jianzhangbjz: Re-titling can only be requested by trusted users, like repository collaborators.

In response to this:

/retitle Bug 1870453: Should not compare the digest if cannot the new update pod's imageID

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@jianzhangbjz: This pull request references Bugzilla bug 1870453, which is invalid:

• expected the bug to be open, but it isn't
• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (DUPLICATE) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1870453: Should not compare the digest if cannot the new update pod's imageID

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jianzhangbjz]

/bugzilla refresh

[openshift-ci-robot]

@jianzhangbjz: This pull request references Bugzilla bug 1870453, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jianzhangbjz]

/retest

[jianzhangbjz]

@exdx Could you help have a review again? Thanks!

[exdx]

With the new logic in place in podReady() this should never happen (the digest being "") but it's still helpful to have a log here just in case.

/hold cancel
/lgtm

[kevinrizza]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianzhangbjz, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kevinrizza]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jianzhangbjz: All pull requests linked via external trackers have merged:

• operator-framework/operator-lifecycle-manager#1729

Bugzilla bug 1870453 has been moved to the MODIFIED state.

In response to this:

Bug 1870453: Should not compare the digest if cannot the new update pod's imageID

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jianzhangbjz]

Thanks for reviewing!