WIP: prevent no-op hotlooping on Operators

[sjenning]

xref https://bugzilla.redhat.com/show_bug.cgi?id=1888073

@njhale

General idea is to cache the resourceVersion of the Operator the last time we updated it. If a component resource changes, unset the cached resourceVersion for force a reconcile. If the Operator itself changes (which might have been caused by us updating it), check the last resourceVersion we observed for it. If it is the same, the reconcile was caused by our own update and we can bail out, breaking the reconciliation hot loop.

[openshift-ci-robot]

@sjenning: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

WIP: prevent no-op hotlooping on Operators

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sjenning
To complete the pull request process, please assign ecordell after the PR has been reviewed.
You can assign the PR to them by writing /assign @ecordell in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

Hi @sjenning. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@sjenning: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

WIP: prevent no-op hotlooping on Operators

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@sjenning: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

WIP: prevent no-op hotlooping on Operators

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[of-deploy-bot]

This PR failed 1 out of 1 times with 2 individual failed tests and 4 skipped tests. A test is considered flaky if failed on multiple commits.

totaltestcount: 1
failedtestcount: 1
flaketestcount: 2
skippedtestcount: 4
flaketests:

• classname: End-to-end
  name: 'Operator when a subscription to a package exists should automatically
  adopt components'
  counts: 3
  details:

  • count: 3
    error: |4-

    /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/operator_test.go:291
    Timed out after 60.000s.
    Error: Unexpected non-nil/non-zero extra argument at index 1:
    	<*errors.StatusError>: &errors.StatusError{ErrStatus:v1.Status{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ListMeta:v1.ListMeta{SelfLink:"", ResourceVersion:"", Continue:"", RemainingItemCount:(*int64)(nil)}, Status:"Failure", Message:"operators.operators.coreos.com \"kiali.ns-ghkb4\" not found", Reason:"NotFound", Details:(*v1.StatusDetails)(0xc000a67ce0), Code:404}}
    /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/operator_test.go:296
    

  meandurationsec: 94.07054966666666
• classname: End-to-end
  name: 'Install Plan creation with permissions'
  counts: 1
  details:

  • count: 1
    error: |4-

    /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:1994
    
    	Error Trace:	installplan_e2e_test.go:2073
    	            				runner.go:113
    	            				runner.go:64
    	            				it_node.go:26
    	            				spec.go:215
    	            				spec.go:138
    	            				spec_runner.go:200
    	            				spec_runner.go:170
    	            				spec_runner.go:66
    	            				suite.go:62
    	            				ginkgo_dsl.go:226
    	            				ginkgo_dsl.go:214
    	            				e2e_test.go:54
    	Error:      	Received unexpected error:
    	            	timed out waiting for the condition
    
    /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/stretchr/testify/require/require.go:1005
    

  meandurationsec: 330.741224
  skippedtests:
• classname: End-to-end
  name: 'Subscriptions create required objects from Catalogs Given a Namespace
  when a CatalogSource is created with a bundle that contains prometheus objects
  creating a subscription using the CatalogSource should have created the expected
  prometheus objects'
  counts: 1
  details: []
  meandurationsec: 9.122374
• classname: End-to-end
  name: 'Subscriptions create required objects from Catalogs Given a Namespace
  when a CatalogSource is created with a bundle that contains prometheus objects
  creating a subscription using the CatalogSource should install the operator
  successfully'
  counts: 1
  details: []
  meandurationsec: 15.900449
• classname: End-to-end
  name: 'Catalog image update'
  counts: 1
  details: []
  meandurationsec: 0.549187
• classname: End-to-end
  name: 'Subscription updates existing install plan'
  counts: 1
  details: []
  meandurationsec: 0.515615

[sjenning]

opened #1816 for master. We can review there and pick back from that PR.