-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1889838: fix race in Operator reconcilation #1823
Bug 1889838: fix race in Operator reconcilation #1823
Conversation
@sjenning: This pull request references Bugzilla bug 1889838, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @sjenning. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@sjenning: This pull request references Bugzilla bug 1889838, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @njhale |
@sjenning: This pull request references Bugzilla bug 1889838, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@sjenning: This pull request references Bugzilla bug 1889838, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
checking for flake |
/test unit |
/retest |
/test unit |
1 similar comment
/test unit |
5 green units tests runs in a row. Looks to have resolved the issue. |
/test e2e-upgrade |
1 similar comment
/test e2e-upgrade |
/approve Just waiting on an LGTM now. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njhale, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test e2e-upgrade |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@sjenning: All pull requests linked via external trackers have merged: Bugzilla bug 1889838 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
xref https://bugzilla.redhat.com/show_bug.cgi?id=1889838
Fixes race in Operator reconciliation that causes unit test flake introduced by #1816
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/operator-framework_operator-lifecycle-manager/1822/pull-ci-operator-framework-operator-lifecycle-manager-release-4.6-unit/1318548827241713664
@njhale @ecordell