Add OperatorCondition status sync and update operator upgradeable check

[dinhxuanvu]

OperatorCondition controller will update its status to refect the
changes on its spec regarding the operator conditions that are reported
by the operators themselves. In turn, operators can read the status
to confirm if OLM has processed the spec changes.

OLM will not take actions on upgradeable condition if the status is
stale using ObservedGeneration and Generation check.

Signed-off-by: Vu Dinh vudinh@outlook.com

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1927340.

Description of the change:

Motivation for the change:

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /doc
• Commit messages sensible and descriptive

[openshift-ci]

@dinhxuanvu: This pull request references Bugzilla bug 1927340, which is invalid:

• expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1927340: Add OperatorCondition status sync and update operator upgradeable check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[timflannagan]

The BZ bot will automatically move the BZ state to POST once this PR lands but we only want that behavior for downstream PRs. I'm going to add a link to the BZ in your PR description instead.

/retitle Add OperatorCondition status sync and update operator upgradeable check

[openshift-ci]

@dinhxuanvu: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Add OperatorCondition status sync and update operator upgradeable check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dinhxuanvu]

The proposal: https://hackmd.io/9wG20hu5TU-y1HrkhvcsZQ?view FYI

[awgreene]

Please remove the FIT test, looks good otherwise.

[dinhxuanvu]

@ecordell PTAL

[awgreene]

A few nits, but it looks great!

[awgreene]

Overall this all looks good to me, most of the points I raised are nits so I'll add the /approve label.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: dinhxuanvu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kevinrizza]

/lgtm

[dinhxuanvu]

/cherry-pick release-4.7

[openshift-cherrypick-robot]

@dinhxuanvu: #2160 failed to apply on top of branch "release-4.7":

Applying: Add OperatorCondition status sync and update operator upgradeable check
Applying: Update OperatorCondition Role and e2e test case
Applying: Address various issues with OperatorCondition codebase
Using index info to reconstruct a base tree...
M	deploy/chart/crds/0000_50_olm_00-operatorconditions.crd.yaml
M	go.mod
M	go.sum
M	pkg/controller/operators/adoption_controller.go
M	pkg/controller/operators/olm/operator.go
M	pkg/lib/operatorlister/lister.go
M	vendor/github.com/operator-framework/api/crds/zz_defs.go
M	vendor/github.com/operator-framework/api/pkg/validation/internal/operatorhub.go
M	vendor/github.com/operator-framework/api/pkg/validation/validation.go
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Auto-merging vendor/github.com/operator-framework/api/pkg/validation/validation.go
CONFLICT (content): Merge conflict in vendor/github.com/operator-framework/api/pkg/validation/validation.go
Auto-merging vendor/github.com/operator-framework/api/pkg/validation/internal/operatorhub.go
CONFLICT (content): Merge conflict in vendor/github.com/operator-framework/api/pkg/validation/internal/operatorhub.go
Auto-merging vendor/github.com/operator-framework/api/crds/zz_defs.go
CONFLICT (content): Merge conflict in vendor/github.com/operator-framework/api/crds/zz_defs.go
Auto-merging pkg/lib/operatorlister/lister.go
Auto-merging pkg/controller/operators/olm/operator.go
Auto-merging pkg/controller/operators/adoption_controller.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
Auto-merging deploy/chart/crds/0000_50_olm_00-operatorconditions.crd.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 Address various issues with OperatorCondition codebase
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.