-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install.sh should not abort if openshift olm is not installed #2211
install.sh should not abort if openshift olm is not installed #2211
Conversation
Hi @jmazzitelli. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
fixes: operator-framework#2210 Signed-off-by: John Mazzitelli <mazz@redhat.com>
c7c8059
to
fb6e5e7
Compare
added sign-off in commit |
@timflannagan I had to add the sign-off to the commit - you may need to kick this again |
/lgtm |
Not sure what else is needed - the tide check is pending with "Not mergeable. Needs approved label" I assume I'll need a project admin to label with |
/approve |
Thanks for fixing this! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, jmazzitelli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick v0.18.x |
@timflannagan: new pull request created: #2221 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Closes #2210