Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install.sh should not abort if openshift olm is not installed #2211

Merged

Conversation

jmazzitelli
Copy link
Contributor

Closes #2210

@openshift-ci openshift-ci bot requested review from ecordell and njhale June 21, 2021 15:10
@openshift-ci
Copy link

openshift-ci bot commented Jun 21, 2021

Hi @jmazzitelli. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 21, 2021
@timflannagan
Copy link
Contributor

/lgtm
/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 21, 2021
fixes: operator-framework#2210
Signed-off-by: John Mazzitelli <mazz@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2021
@jmazzitelli
Copy link
Contributor Author

added sign-off in commit

@jmazzitelli
Copy link
Contributor Author

@timflannagan I had to add the sign-off to the commit - you may need to kick this again

@timflannagan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2021
@jmazzitelli
Copy link
Contributor Author

Not sure what else is needed - the tide check is pending with "Not mergeable. Needs approved label"

I assume I'll need a project admin to label with /approved to keep it going.

cc @timflannagan

@benluddy
Copy link
Contributor

/approve

@benluddy
Copy link
Contributor

Thanks for fixing this!

@openshift-ci
Copy link

openshift-ci bot commented Jun 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, jmazzitelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2021
@openshift-merge-robot openshift-merge-robot merged commit cd40303 into operator-framework:master Jun 21, 2021
@jmazzitelli jmazzitelli deleted the fix-install-sh branch June 21, 2021 18:29
@timflannagan
Copy link
Contributor

/cherrypick v0.18.x

@openshift-cherrypick-robot

@timflannagan: new pull request created: #2221

In response to this:

/cherrypick v0.18.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install.sh does not work if you have never installed OLM before
5 participants