feat(sub): Include IP failure condition message in sub status condition #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
anik120
force-pushed
the
subscription-message-backup
branch
2 times, most recently
from
f27a108
to
3ab249f
Compare
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
Currently when an InstallPlan fails, due to bundle unpacking error
is pending due to errors like invalid operatorgroup, or pending bundle unpacking job
the reason is propagated to the Subscription that owns it. The message for the failure is
however missing from the Subscription condition.
eg
```
kind: Subscription
status:
conditions:
- lastTransitionTime: "2021-07-07T17:55:20Z"
reason: Installing
status: "True"
type: InstallPlanPending
```
This PR propagates the message assosiated with the reason in the InstallPlan
condition when an InstallPlan is either pending, or has failed permanantly.
eg
```
kind: Subscription
status:
conditions:
- lastTransitionTime: "2021-07-07T17:55:20Z"
message: no operator group found that is managing this namespace
reason: Installing
status: "True"
type: InstallPlanPending
```
Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
anik120
force-pushed
the
subscription-message-backup
branch
from
3ab249f
to
303608d
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
awgreene
reviewed
Jul 19, 2021
| } | ||
| if cond := status.GetCondition(v1alpha1.InstallPlanInstalled); cond.Status != corev1.ConditionUnknown { | ||
| if cond.Message != "" { | ||
| str = cond.Message |
There was a problem hiding this comment.
This overwrites the str value found after iterating over the list of bundleLookups. This seems intentional, as a successful install of an IP should be communicated rather than failed bundleLookup messages.
Could we check if the IP was installed and return the str before iterating through the bundleLookups?
awgreene
approved these changes
Jul 19, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, ankitathomas, awgreene The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Currently when an InstallPlan fails, due to bundle unpacking error
is pending due to errors like invalid operatorgroup, or pending bundle unpacking job
the reason is propagated to the Subscription that owns it. The message for the failure is
however missing from the Subscription condition.
eg
This PR propagates the message assosiated with the reason in the InstallPlan
condition when an InstallPlan is either pending, or has failed permanantly.
eg
Motivation for the change:
Reviewer Checklist
/doc