fix(openshift): drop z from next calculated y-stream #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
njhale
force-pushed
the
openshift/fix/upgrade-blocking
branch
2 times, most recently
from
6d590e9
to
9d223ae
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevinrizza, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This looks reasonable to me. I'd like to get another opinion with someone more familiar with semver syntax but feel free to remove the hold if this is time sensitive. /lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
estroz
reviewed
Aug 12, 2021
When determining operator compatibility, drop z and build
versions in the calculation of the next Y-stream (minor)
release of OpenShift.
e.g. If the current version is v4.9.5+build, the next Y-stream is
calculated as v4.10.0.
If a pre-release is included, drop it as well but don't increment
the minor version.
e.g. If the current version is v4.10.0-rc, the next Y-stream is
calculated as v4.10.0.
Before this change, the next Y-stream was the result of simply
iterating the cluster's minor version. When the cluster was at
a patch version greater than that specified by an operator, upgrades
would be erroneously blocked.
e.g. If the current version was v4.9.5, the next version would be
calculated as v4.10.5, which would block upgrades on operators with
max versions set to v4.10 -- or more explicitly [v4.10.0, v4.10.5) (')'
is read "exclusive").
Signed-off-by: Nick Hale <njohnhale@gmail.com>
njhale
force-pushed
the
openshift/fix/upgrade-blocking
branch
from
9d223ae
to
bf11c93
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When determining operator compatibility, drop z and build
versions in the calculation of the next Y-stream (minor)
release of OpenShift.
e.g. If the current version is v4.9.5+build, the next Y-stream is
calculated as v4.10.0.
If a pre-release is included, drop it as well but don't increment
the minor version.
e.g. If the current version is v4.10.0-rc, the next Y-stream is
calculated as v4.10.0.
Before this change, the next Y-stream was the result of simply
iterating the cluster's minor version. When the cluster was at
a patch version greater than that specified by an operator, upgrades
would be erroneously blocked.
e.g. If the current version was v4.9.5, the next version would be
calculated as v4.10.5, which would block upgrades on operators with
max versions set to v4.10 -- or more explicitly [v4.10.0, v4.10.5) (')'
is read "exclusive").
For further motivation, see https://bugzilla.redhat.com/show_bug.cgi?id=1993286