Fix 2327: Detecting OLM existence before start to install

[morningspace]

Signed-off-by: Ying Mo morningspace@yahoo.com

Description of the change:

Adding logic in install.sh to check if OLM has already been installed in olm namespace before going forward.

Motivation for the change:

This PR is aimed to fix the issue documented here

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /doc
• Commit messages sensible and descriptive

[openshift-ci]

Hi @morningspace. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[timflannagan]

/lgtm

[timflannagan]

Thanks

$ kind create cluster
$ kubectx kind-kind
$ ./scripts/install.sh v0.18.3
customresourcedefinition.apiextensions.k8s.io/catalogsources.operators.coreos.com created
customresourcedefinition.apiextensions.k8s.io/clusterserviceversions.operators.coreos.com created
customresourcedefinition.apiextensions.k8s.io/installplans.operators.coreos.com created
...
$ ./scripts/install.sh v0.18.3
OLM is already installed in olm namespace. Exiting...
$ k create ns openshift-operator-lifecycle-manager
$ k apply -f https://raw.githubusercontent.com/openshift/operator-framework-olm/master/manifests/0000_50_olm_07-olm-operator.deployment.yaml
deployment.apps/olm-operator created
$ ./scripts/install.sh v0.18.3
OLM is already installed in a different configuration. This is common if you are not running a vanilla Kubernetes cluster. Exiting...

[timflannagan]

/lgtm

[timflannagan]

/ok-to-test

[morningspace]

@timflannagan I am seeing the e2e test is failed due to error occurred at https://github.com/operator-framework/operator-lifecycle-manager/blob/master/test/e2e/util_test.go#L497. But I could not image that's caused by this PR. Is it because of test-run slowness or something happens randomly?

Failure details could be found at: https://github.com/operator-framework/operator-lifecycle-manager/runs/3434684793?check_suite_focus=true#step:4:2106 There are two CSVs created by the test case were not able to be deleted after waiting about 60.003s.

[timflannagan]

@morningspace I wouldn't worry too much about those e2e failures as the testing suite can be flaky at times. IIRC, we don't actually use the install.sh bash script anywhere in the default testing environment. It looks like running make e2e-local, which is what the e2e-tests/run-e2e-tests workflow is running under-the-hood, is using helm to scaffold and create an installation in the testing executable.

[kevinrizza]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinrizza, morningspace, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kevinrizza]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.