Reduce resolver dependencies on operator-registry and operator-lifecycle-manager. #2337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Luddy <bluddy@redhat.com>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
approved
benluddy
force-pushed
the
resolver-source-refactor
branch
from
486f2d7
to
2f6b3f2
Compare
benluddy
changed the title
The most significant change is the introduction of a new Source interface, which represents a single source of cache entries. In the existing implementation, the cache was hardcoded to fetch content from the operator-registry gRPC API on misses. This was a barrier to off-cluster tools and other applications that should be able to perform resolution without running a registry server. A number of test fixtures were affected (for the better) because it's now possible to directly configure the real Cache implementation to retrieve test content without using of test doubles. Signed-off-by: Ben Luddy <bluddy@redhat.com>
benluddy
force-pushed
the
resolver-source-refactor
branch
from
2f6b3f2
to
be57abb
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
dinhxuanvu
approved these changes
Sep 1, 2021
| s.snapshots[i], s.snapshots[j] = s.snapshots[j], s.snapshots[i] | ||
| } | ||
|
|
||
| func (s *CatalogSnapshot) Find(p ...OperatorPredicate) []*Operator { | ||
| func (s *snapshotHeader) Find(p ...OperatorPredicate) []*Operator { |
There was a problem hiding this comment.
Nit: Can we move all of types to the head of the file? It is difficult to review and understand the code when you use a type at the top of the file and the type itself is declared somewhere at the bottom of the file.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, dinhxuanvu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the ongoing work to allow the runtime dependency resolution features of catalog-operator to be reusable outside of OLM.