Update the CONTRIBUTING.md guidelines #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timflannagan
force-pushed
the
update-contributing-doc
branch
from
d655582
to
c7aee38
Compare
kevinrizza
reviewed
Sep 8, 2021
kevinrizza
reviewed
Sep 8, 2021
timflannagan
force-pushed
the
update-contributing-doc
branch
from
9186872
to
76db2d5
Compare
|
(testing out the updated CI workflows that should skip running CI on this PR 🤞) |
timflannagan
force-pushed
the
update-contributing-doc
branch
from
76db2d5
to
7e4fe30
Compare
|
Nice it seems to have worked 🎉 |
Signed-off-by: timflannagan <timflannagan@gmail.com>
Signed-off-by: timflannagan <timflannagan@gmail.com>
timflannagan
force-pushed
the
update-contributing-doc
branch
2 times, most recently
from
8ac8dab
to
fcd934e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njhale, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
timflannagan
force-pushed
the
update-contributing-doc
branch
from
fcd934e
to
25c47fb
Compare
estroz
reviewed
Sep 13, 2021
estroz
reviewed
Sep 13, 2021
estroz
reviewed
Sep 13, 2021
…and review guidelines Signed-off-by: timflannagan <timflannagan@gmail.com>
timflannagan
force-pushed
the
update-contributing-doc
branch
from
25c47fb
to
9bfad9b
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change:
Reviewer Checklist
/doc