Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add summary and description for prometheus alerts #2361

Merged
merged 4 commits into from
Sep 21, 2021
Merged

Add summary and description for prometheus alerts #2361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5decfac
fix(prometheus): add summary and description for prometheus alerts
Sep 16, 2021
b0966b3
fix(prometheus): updating language on description for alerts
Sep 16, 2021
9317022
Merge branch 'operator-framework:master' into master
tylerslaton Sep 17, 2021
c9ec25b
fix(prometheus): change copy on alerts for PR
Sep 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions deploy/chart/templates/0000_90_olm_01-prometheus-rule.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ spec:
severity: warning
namespace: "{{ "{{ $labels.namespace }}" }}"
annotations:
summary: CSV failed for over 2 minutes
description: Fires whenever a CSV has been in the failed phase for more than 2 minutes.
message: Failed to install Operator {{ printf "{{ $labels.name }}" }} version {{ printf "{{ $labels.version }}" }}. Reason-{{ printf "{{ $labels.reason }}" }}
- alert: CsvAbnormalOver30Min
expr: csv_abnormal{phase=~"(^Replacing$|^Pending$|^Deleting$|^Unknown$)"}
Expand All @@ -26,6 +28,8 @@ spec:
severity: warning
namespace: "{{ "{{ $labels.namespace }}" }}"
annotations:
summary: CSV abnormal for over 30 minutes
description: Fires whenever a CSV is in the Replacing, Pending, Deleting, or Unkown phase for more than 30 minutes.
message: Failed to install Operator {{ printf "{{ $labels.name }}" }} version {{ printf "{{ $labels.version }}" }}. Phase-{{ printf "{{ $labels.phase }}" }} Reason-{{ printf "{{ $labels.reason }}" }}
- name: olm.installplan.rules
rules:
Expand All @@ -34,5 +38,7 @@ spec:
labels:
severity: warning
annotations:
summary: API returned a warning when modifying an operator
tylerslaton marked this conversation as resolved.
Show resolved Hide resolved
description: Fires whenever the API server returns a warning when attempting to modify an operator.
message: The API server returned a warning during installation or upgrade of an operator. An Event with reason "AppliedWithWarnings" has been created with complete details, including a reference to the InstallPlan step that generated the warning.
{{ end }}
2 changes: 2 additions & 0 deletions pkg/controller/operators/catalog/testdata/prometheusrule.cr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ spec:
rules:
- alert: SeriousAlert
annotations:
summary: Serious Alert!
description: This is a test alert, it is not real.
message: A serious alert!
expr: alert_status{prioirity="Serious"}
labels:
Expand Down