Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrap csv e2e test creation artifacts in Eventually statements #2387

Merged

Conversation

exdx
Copy link
Member

@exdx exdx commented Oct 1, 2021

Signed-off-by: Daniel Sover dsover@redhat.com

Description of the change:
Noticed a flake locally

• Failure in Spec Setup (BeforeEach) [60.056 seconds]
ClusterServiceVersion
/Users/dsover/code/src/operator-lifecycle-manager/test/e2e/csv_e2e_test.go:39
  when a CustomResourceDefinition was installed alongside a ClusterServiceVersion
  /Users/dsover/code/src/operator-lifecycle-manager/test/e2e/csv_e2e_test.go:60
    can satisfy an unassociated ClusterServiceVersion's ownership requirement if replaced by an associated ClusterServiceVersion [BeforeEach]
    /Users/dsover/code/src/operator-lifecycle-manager/test/e2e/csv_e2e_test.go:180

    Expected success, but got an error:
        <*errors.StatusError | 0xc0028c57c0>: {
            ErrStatus: {
                TypeMeta: {Kind: "", APIVersion: ""},
                ListMeta: {
                    SelfLink: "",
                    ResourceVersion: "",
                    Continue: "",
                    RemainingItemCount: nil,
                },
                Status: "Failure",
                Message: "object is being deleted: namespaces \"test-namespace-1\" already exists",
                Reason: "AlreadyExists",
                Details: {
                    Name: "test-namespace-1",
                    Group: "",
                    Kind: "namespaces",
                    UID: "",
                    Causes: nil,
                    RetryAfterSeconds: 0,
                },
                Code: 409,
            },
        }
        object is being deleted: namespaces "test-namespace-1" already exists

    /Users/dsover/code/src/operator-lifecycle-manager/test/e2e/csv_e2e_test.go:72

Motivation for the change:
Reduce flakiness

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive

test/e2e/csv_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/csv_e2e_test.go Outdated Show resolved Hide resolved
…ach block

Signed-off-by: Daniel Sover <dsover@redhat.com>
Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: exdx, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 8, 2021
@openshift-merge-robot openshift-merge-robot merged commit a94b10b into operator-framework:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
3 participants