Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): Remove the PreExistingCRDOwnerIsReplaced e2e test case #2388

Merged

Conversation

dinhxuanvu
Copy link
Member

The PreExistingCRDOwnerIsReplaced test case is no longer applicable
as the ownership replacement check has been removed from olm. This
test was introduced when olm only allowed one single ownership of
CRD.

Signed-off-by: Vu Dinh vudinh@outlook.com

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive

The PreExistingCRDOwnerIsReplaced test case is no longer applicable
as the ownership replacement check has been removed from olm. This
test was introduced when olm only allowed one single ownership of
CRD.

Signed-off-by: Vu Dinh <vudinh@outlook.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2021
@dinhxuanvu dinhxuanvu requested review from timflannagan and njhale and removed request for joelanford and hasbro17 October 4, 2021 22:48
Copy link
Contributor

@timflannagan timflannagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any PR(s) that you could link to provide more context as when this functionality was removed?

@dinhxuanvu
Copy link
Member Author

Is there any PR(s) that you could link to provide more context as when this functionality was removed?

Here is the original PR for CRD upgrade feature for single ownership that I did (PR). Then, Jeff did another PR to allow multiple ownership upgrade (PR). Since then, that check has been removed as if you look at the CRD upgrade code in step.go, there is not ownership check anymore as it has been removed with this PR.

@timflannagan
Copy link
Contributor

Thanks, I think I'm convinced this test is no longer needed.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2021
@openshift-merge-robot openshift-merge-robot merged commit 1237d38 into operator-framework:master Oct 5, 2021
@timflannagan timflannagan mentioned this pull request Oct 6, 2021
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants