test/e2e: wrap subscription e2e test logic in Eventually statement #2392
Conversation
| @@ -467,9 +467,14 @@ var _ = Describe("Subscription", func() { | |||
| require.NoError(GinkgoT(), err) | |||
|
|
|||
| // Wait for the subscription to begin upgrading to csvB | |||
| subscription, err = fetchSubscription(crc, testNamespace, subscriptionName, subscriptionStateUpgradePendingChecker) | |||
There was a problem hiding this comment.
I wonder if this should be handled at the fetchSubscription layer, and instead, create a new checker type.
/lgtm
There was a problem hiding this comment.
I think we probably want to start getting rid of a lot of the custom test framework if we can write test specs simply at the call sites.
it seems like maintaining custom test frameworks is one place where the cost of being DRY outweighs its value
exdx
force-pushed
the
fix/e2e-sub-with-starting-csv
branch
from
2732fd6
to
ed1508e
Compare
Signed-off-by: Daniel Sover <dsover@redhat.com>
exdx
force-pushed
the
fix/e2e-sub-with-starting-csv
branch
from
ed1508e
to
3bde04e
Compare
|
/approve |
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: exdx, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Signed-off-by: Daniel Sover dsover@redhat.com
Description of the change:
Fixes up the "with starting CSV" test by wrapping a flake-prone path with an Eventually()
Motivation for the change:
Flaky test
Reviewer Checklist
/doc