Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CI github workflows #2446

Merged

Conversation

timflannagan
Copy link
Contributor

Signed-off-by: timflannagan timflannagan@gmail.com

Description of the change:
Update the various CI workflows names that are run on a per-PR basis to
help distinguish between individual action runs when interacting with
the github UI.

Motivation for the change:

Interacting with the 'actions' tab in the Github UI can be challenging when trying to view individual action runs. This is because all of the CI-related workflows are currently named 'ci', which makes filtering out for specific workflows more challenging, requiring you to hover over each action to determine the resolved link. The following screenshot shows the current interaction:

Screenshot from 2021-11-12 12-37-59

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive

@timflannagan timflannagan force-pushed the rename-ci-workflows branch 2 times, most recently from 743001c to a1d47ea Compare November 12, 2021 17:41
Copy link
Contributor Author

@timflannagan timflannagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick note: I elected to not update the e2e-tests workflow as the 'ci' workflow name still seemed appropriate. I don't have a strong opinion in either case, so I'm happy to update and change that as well.

Update the various CI workflows names that are run on a per-PR basis to
help distinguish between individual action runs when interacting with
the github UI.

Signed-off-by: timflannagan <timflannagan@gmail.com>
…nd remove any 'e2e' references

Signed-off-by: timflannagan <timflannagan@gmail.com>
Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Dec 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhale, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2021
@awgreene
Copy link
Member

awgreene commented Dec 1, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2021
@timflannagan
Copy link
Contributor Author

Manually overriding the failed e2e test as this PR only affects the naming of the workflow(s) and nothing user-facing.

@timflannagan timflannagan merged commit d92ef2c into operator-framework:master Dec 1, 2021
@timflannagan timflannagan deleted the rename-ci-workflows branch December 1, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants