Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Maintainers File #2456

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Introduce Maintainers File #2456

merged 1 commit into from
Dec 8, 2021

Conversation

awgreene
Copy link
Member

This commit introduces the MAINTAINERS.md file in an effort
to decouple project maintainer status from approval and lgtm
permissions relied on by the project automated continuous
integration tooling.

@openshift-ci
Copy link

openshift-ci bot commented Nov 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2021
timflannagan
timflannagan reviewed Nov 17, 2021
View reviewed changes
MAINTAINERS.md Outdated Show resolved Hide resolved
@timflannagan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2021
@timflannagan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2021
@awgreene
Introduce Maintainers File
6113a14 
This commit introduces the MAINTAINERS.md file in an effort
to decouple project maintainer status from approval and lgtm
permissions relied on by the project automated continuous
integration tooling.

Signed-off-by: Alexander Greene <greene.al1991@gmail.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2021
@timflannagan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2021
@timflannagan timflannagan mentioned this pull request Nov 30, 2021
Closed
5 tasks
@timflannagan
Copy link
Contributor

Feel free to manually merge (manually throwing the hold on this PR for my own edification) but I'd like to attempt to an update to the existing set of CI-related github workflows as the paths-ignore stanza doesn't play well with explicitly defined required workflow context's that are defined. The likely solution is moving towards dynamic filtering, which I took a stab at implementing in #2500.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2021
@awgreene
Copy link
Member Author

awgreene commented Dec 2, 2021

/retest

@timflannagan
Copy link
Contributor

(just recycling the checks as we should've merged the update to the workflows to they don't block tide from merging markdown-only PRs)

@timflannagan timflannagan reopened this Dec 8, 2021
@timflannagan
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2021
@openshift-merge-robot openshift-merge-robot merged commit 4f5c16c into operator-framework:master Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timflannagan timflannagan timflannagan left review comments

@gallettilance gallettilance Awaiting requested review from gallettilance

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees

@timflannagan timflannagan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@awgreene @timflannagan @openshift-merge-robot