pkg,test: Remove duplicate package imports #2501
Conversation
Update various pkg,test packages are removed any obvious duplicate package imports that violate local static linters. Signed-off-by: timflannagan <timflannagan@gmail.com>
| @@ -6,7 +6,6 @@ import ( | |||
|
|
|||
| "github.com/operator-framework/api/pkg/operators/v1alpha1" | |||
| "github.com/operator-framework/operator-lifecycle-manager/pkg/controller/registry/resolver/cache" | |||
| "github.com/operator-framework/operator-registry/pkg/registry" | |||
There was a problem hiding this comment.
non-blocking question: Would it make sense to keep the default name and remove the alternatively named one (opregistry) instead?
There was a problem hiding this comment.
Answering both comments: totally fair question - I mainly went with my gut locally and tried to avoid removing the package import alias that was used more frequently. The one caveat is more common/standardized package imports that are used and I value consistency over standardization generally speaking.
| @@ -14,7 +14,6 @@ import ( | |||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | |||
| "k8s.io/apimachinery/pkg/labels" | |||
|
|
|||
| "github.com/operator-framework/api/pkg/lib/version" | |||
There was a problem hiding this comment.
non-blocking question: Same as above
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njhale, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Update various pkg,test packages are removed any obvious duplicate
package imports that violate local static linters.
Signed-off-by: timflannagan timflannagan@gmail.com
Description of the change:
Remove any obvious duplicate package imports that are identified by local, static linters.
Motivation for the change:
Reduce duplicate package imports to help increase maintainability over time (and help alleviate a huge diff when migrating to enforcing this eventually in CI).
Reviewer Checklist
/doc