Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github alias links in MAINTAINERS.md #2533

Conversation

timflannagan
Copy link
Contributor

@timflannagan timflannagan commented Dec 20, 2021

Prepend the https://github.com to ensure that markdown rendered links
are not resolved as local links.

Signed-off-by: timflannagan timflannagan@gmail.com

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive

Prepend the https://github.com to ensure that markdown rendered links
are not resolved as local links.

Signed-off-by: timflannagan <timflannagan@gmail.com>
@awgreene
Copy link
Member

/approve

@openshift-ci
Copy link

openshift-ci bot commented Dec 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2021
@awgreene
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2021
@timflannagan
Copy link
Contributor Author

Force merging as these changes won't affect anything user facing and it already has the requisite labels present.

@timflannagan timflannagan merged commit bfe8f0f into operator-framework:master Dec 20, 2021
@timflannagan timflannagan deleted the cleanup/fix-maintainers-github-alias-links branch December 20, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants