Do not modify object from the lister cache #2562
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
I am going to spend a bit of time looking for instances where objects returned from the lister are mutated. |
openshift-ci
bot
added
the
do-not-merge/hold
awgreene
force-pushed
the
return-copy-from-lister
branch
from
22731cc
to
64cd2cc
Compare
awgreene
force-pushed
the
return-copy-from-lister
branch
from
64cd2cc
to
f14c205
Compare
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
awgreene
changed the title
|
Approach looks good to me, just need to make sure that we update the branch with the latest changes. |
awgreene
force-pushed
the
return-copy-from-lister
branch
from
f14c205
to
edb9f44
Compare
|
Nice work! /lgtm |
|
/retest |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/lgtm |
Problem: Objects retrieved from the lister should not be modified. Solution: In locations where an object originating from the lister cache must be modified, modify a copy of the object instead. Signed-off-by: Alexander Greene <greene.al1991@gmail.com>
awgreene
force-pushed
the
return-copy-from-lister
branch
from
edb9f44
to
1920817
Compare
|
/lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
23 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
Holding so the bot doesn't go crazy. /hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
Problem: Objects retrieved from the lister should
not be modified.
Solution: Return a DeepCopy of the object retrieved
from the lister which can then be manipulated as
needed.
Signed-off-by: Alexander Greene greene.al1991@gmail.com