Add workflow for automatically rebasing open PRs #2612
Conversation
Introduce a workflow that's reponsible for automatically rebasing open PRs when a commit has landed in the default (e.g. master) branch. Ensure a comment is posted on that PR when the rebasing action job has failed. Signed-off-by: timflannagan <timflannagan@gmail.com>
openshift-ci
bot
added
the
approved
| - uses: peter-evans/rebase@v1 | ||
| with: | ||
| base: master |
There was a problem hiding this comment.
I think we'll need to give this workflow a custom PAT token to ensure that automatic rebasing works as intended. We've seen in the o-f/combo repository PRs that are way behind the latest HEAD of master fail to be rebased when commits that change the workflow definitions as doing so requires the workflow PAT token scope to be present.
There was a problem hiding this comment.
Great work @timflannagan, we'll keep an eye out for the need for a PAT token.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Description of the change:
Introduce a workflow that's reponsible for automatically rebasing open
PRs when a commit has landed in the default (e.g. master) branch. Ensure
a comment is posted on that PR when the rebasing action job has failed.
Motivation for the change:
This repository currently specifies the "require branches to be up-to-date before merging" branch protection rule for the master branch to avoid merging PRs that break or regress master builds.
Reviewer Checklist
/doc