Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: Remove the automatic rebase action #2620

Conversation

timflannagan
Copy link
Contributor

Description of the change:
Remove the rebase workflow that's responsible for automatically
rebasing open PRs. The peter-evans/rebase action requires additional
permissions than the default token we provide to actions at runtime, and
appears to only have support for failing fast when it encounters an
error rebasing an open PR, which isn't ideal for this repository.

Motivation for the change:
Remove a permafailing action that doesn't provide a ton of value right now to this repository.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive

Remove the `rebase` workflow that's responsible for automatically
rebasing open PRs. The peter-evans/rebase action requires additional
permissions than the default token we provide to actions at runtime, and
appears to only have support for failing fast when it encounters an
error rebasing an open PR, which isn't ideal for this repository.

Signed-off-by: timflannagan <timflannagan@gmail.com>
@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2022
@akihikokuroda
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2022
@openshift-merge-robot openshift-merge-robot merged commit 900c7a7 into operator-framework:master Feb 10, 2022
@timflannagan timflannagan deleted the ci/remove-autorebase-action branch February 10, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants