Remove unused ttl field from cache.Cache. #2658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
🎉 Thanks! I guess this was a red herring when Ben and I we're debugging the CPU spikes of catalog pods. I thought this may have had something to do with it. |
|
@joelanford Still possible, I moved the hardcoded TTL out of the cache just this week, but there is a still an at-most five minute TTL on snapshots of catalog content from registry pods (#2651). |
The cache itself isn't responsible for snapshot invalidation anymore, but this field has been left behind. Signed-off-by: Ben Luddy <bluddy@redhat.com>
njhale
force-pushed
the
remove-cache-ttl-field
branch
from
8f09257
to
3d1583b
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache itself isn't responsible for snapshot invalidation anymore,
but this field has been left behind.