Bump controller-runtime to v0.11.1 #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: timflannagan <timflannagan@gmail.com>
openshift-ci
bot
added
the
approved
|
/lgtm |
akihikokuroda
approved these changes
Mar 23, 2022
akihikokuroda
approved these changes
Mar 23, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akihikokuroda, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nsapse
pushed a commit
to nsapse/operator-lifecycle-manager
that referenced
this pull request
Mar 28, 2022
Signed-off-by: timflannagan <timflannagan@gmail.com> Signed-off-by: Noah Sapse <nsapse@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: timflannagan timflannagan@gmail.com
Description of the change:
Bump the controller-runtime dependency to v0.11.1 to pick up the partial metadata informer fixes. We previously had to hack around this issue using custom c-r replace pins throughout OLM as we had seen #2628 and the
It("should automatically adopt components")test case(s) regress over time.Previous to these changes, and when testing in downstream CI environments, those test cases I outlined consistently failed as the adoption controller wasn't able to pick up the kiali-operator ServiceAccount resource (as we place a metadata-only watcher on that resource), which resulted in the kiali-operator Operator resource missing that underlying resource in it's list of component references propagated to the status. After incorporating these changes, this test case is no longer failing.
Motivation for the change:
Burn down testing flakes/failures.
Reviewer Checklist
/doc[FLAKE]are truly flaky[FLAKE]tag are no longer flaky