Add importas linting configuration to enforce common package import naming #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
7 tasks
|
Unit test failures are reproducible locally. /hold |
openshift-ci
bot
added
the
do-not-merge/hold
timflannagan
force-pushed
the
ci/add-importas-linter-configuration
branch
from
fb468c8
to
eddc31e
Compare
|
Fixed the unit test failures in my last force push. /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
timflannagan
force-pushed
the
ci/add-importas-linter-configuration
branch
2 times, most recently
from
ba1dc4a
to
fc5e71c
Compare
…aming Signed-off-by: timflannagan <timflannagan@gmail.com>
Signed-off-by: timflannagan <timflannagan@gmail.com>
timflannagan
force-pushed
the
ci/add-importas-linter-configuration
branch
from
fc5e71c
to
25e1546
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Introduce a configuration for the
importasconfiguration for commonly used package imports, e.g. metav1/corev1/appsv1, when running golangci-lint runner. This is currently used in the operator-framework/rukpak repository, and helps lessen reviewer burden as we're focusing less on styling differences.Motivation for the change:
Enforce package import naming for commonly imported packages to lessen the reviewer burden.
Reviewer Checklist
/doc[FLAKE]are truly flaky[FLAKE]tag are no longer flaky