Move operator condition e2e to one namespace per spec #2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
|
/retest-required |
There was a problem hiding this comment.
It looks like we're leaking a CRD but other than that, this LGTM:
$ k get operators
NAME AGE
a-vwlbs.operator-conditions-e2e-qfp5m 2m1s
$ k get operators a-vwlbs.operator-conditions-e2e-qfp5m -o yaml
apiVersion: operators.coreos.com/v1
kind: Operator
metadata:
creationTimestamp: "2022-03-29T13:29:36Z"
generation: 1
name: a-vwlbs.operator-conditions-e2e-qfp5m
resourceVersion: "1918"
uid: 07b7fea3-aa8a-462c-9cc6-e777fb52f8b2
spec: {}
status:
components:
labelSelector:
matchExpressions:
- key: operators.coreos.com/a-vwlbs.operator-conditions-e2e-qfp5m
operator: Exists
refs:
- apiVersion: apiextensions.k8s.io/v1
conditions:
- lastTransitionTime: "2022-03-29T13:29:38Z"
message: no conflicts found
reason: NoConflicts
status: "True"
type: NamesAccepted
- lastTransitionTime: "2022-03-29T13:29:38Z"
message: the initial names have been accepted
reason: InitialNamesAccepted
status: "True"
type: Established
kind: CustomResourceDefinition
name: a-vwlbsrcr7g.cluster.com
$ k get crds
NAME CREATED AT
a-vwlbsrcr7g.cluster.com 2022-03-29T13:29:38Z
catalogsources.operators.coreos.com 2022-03-29T13:27:26Z
clusterserviceversions.operators.coreos.com 2022-03-29T13:27:26Z
installplans.operators.coreos.com 2022-03-29T13:27:28Z
olmconfigs.operators.coreos.com 2022-03-29T13:27:29Z
operatorconditions.operators.coreos.com 2022-03-29T13:27:30Z
operatorgroups.operators.coreos.com 2022-03-29T13:27:31Z
operators.operators.coreos.com 2022-03-29T13:27:33Z
subscriptions.operators.coreos.com 2022-03-29T13:27:33Z
Signed-off-by: perdasilva <perdasilva@redhat.com>
timflannagan
force-pushed
the
refactor_operator_conditions_e2e
branch
from
9b291de
to
e7a2061
Compare
|
It looks like we're waiting for the namespace changes, so throwing a hold so it's easier to distinguish between which refactoring PRs are ready to land. /hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: perdasilva perdasilva@redhat.com
Description of the change:
This PR moves the operator condition e2e test suite to one namespace per spec
Motivation for the change:
CI stability
Reviewer Checklist
/doc[FLAKE]are truly flaky[FLAKE]tag are no longer flaky