Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github,test: Rename the ARTIFACTS_DIR variable to ARTIFACT_DIR #2729

Conversation

timflannagan
Copy link
Contributor

Signed-off-by: timflannagan timflannagan@gmail.com

Description of the change:
Fix the ARTIFACTS_DIR variable and rename that to the proper ARTIFACT_DIR variable so OLM can work on prow-based CI environments.

Motivation for the change:
Maintain consistency with the various CI platforms (e.g. prow)

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky
  • Tests that remove the [FLAKE] tag are no longer flaky

Signed-off-by: timflannagan <timflannagan@gmail.com>
@openshift-ci openshift-ci bot requested review from anik120 and benluddy April 7, 2022 14:38
@openshift-ci
Copy link

openshift-ci bot commented Apr 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2022
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2022
@openshift-merge-robot openshift-merge-robot merged commit 70ec60a into operator-framework:master Apr 7, 2022
@timflannagan timflannagan deleted the ci/rename-artifacts-dir-variable branch April 7, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants