Update ginkgo to v2 #2732
Update ginkgo to v2 #2732
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
perdasilva
force-pushed
the
ginkgo_v2
branch
14 times, most recently
from
32a8cb0
to
47082ae
Compare
.github/workflows/e2e-tests.yml
Outdated
| @@ -19,6 +19,8 @@ jobs: | |||
| - uses: actions/setup-go@v2 | |||
| with: | |||
| go-version: '~1.17' | |||
| - run: mkdir -p artifacts | |||
| - run: go install github.com/onsi/ginkgo/v2/ginkgo@latest | |||
There was a problem hiding this comment.
Had to install ginkgo v2 cli. Calling via go run github.com/onsi/ginkgo/ginkgo still runs v1.
There was a problem hiding this comment.
I think I found a way to execute it similar to before. I had to remove -mod=vendor though
Makefile
Outdated
| @@ -26,7 +26,7 @@ YQ_INTERNAL := go run $(MOD_FLAGS) ./vendor/github.com/mikefarah/yq/v3/ | |||
| KUBEBUILDER_ASSETS := $(or $(or $(KUBEBUILDER_ASSETS),$(dir $(shell command -v kubebuilder))),/usr/local/kubebuilder/bin) | |||
| export KUBEBUILDER_ASSETS | |||
| GO := GO111MODULE=on GOFLAGS="$(MOD_FLAGS)" go | |||
| GINKGO := $(GO) run github.com/onsi/ginkgo/ginkgo | |||
| GINKGO := ginkgo | |||
There was a problem hiding this comment.
go run github.com/onsi/ginkgo/ginkgo runs v1. Had to install the v2 cli locally and use that =(
There was a problem hiding this comment.
I think I found a way to execute it similar to before. I had to remove -mod=vendor though
perdasilva
force-pushed
the
ginkgo_v2
branch
3 times, most recently
from
a32c472
to
ec6cfbb
Compare
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
|
/lgtm |
Signed-off-by: Per Goncalves da Silva pegoncal@redhat.com
Description of the change:
Updates ginkgo to v2
Motivation for the change:
It's about time
Reviewer Checklist
/doc[FLAKE]are truly flaky[FLAKE]tag are no longer flaky