(e2e) Reduce Consistently time for catalogsource_ready metrics check #2739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anik120
force-pushed
the
metrics-e2e-reduce-time
branch
from
78f682c
to
25c91e5
Compare
5 tasks
|
/lgtm |
timflannagan
approved these changes
Apr 27, 2022
openshift-ci
bot
added
do-not-merge/hold
This test was checking for the catalogsource_ready metrics being emitted with a particular value, consistently for a period of time. `Consistently` blocks for the duration of time mentioned (previously 3m). Unfortunately, there is no way to write an `Eventually` that starts polling after an interval, which could have been the non-blocking alternatve to using Consistently to perform the same check. This PR reduces the period of time the test is blocked Consistently to 1m, to reduce the test package's overall runtime. Ref: https://onsi.github.io/gomega/#eventually https://onsi.github.io/gomega/#consistently Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
anik120
force-pushed
the
metrics-e2e-reduce-time
branch
from
25c91e5
to
e7e7864
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
timflannagan
approved these changes
Apr 28, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
oh weird: it looks like approval-acts-as-lgtm isn't enabled for this repository sadly. /lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was checking for the catalogsource_ready metrics being emitted
with a particular value, consistently for a period of time.
Consistentlyblocks for the duration of time mentioned (previously 3m). Unfortunately,
there is no way to write an
Eventuallythat starts polling after aninterval, which could have been the non-blocking alternatve to using
Consistently to perform the same check.
This PR reduces the period of time the test is blocked Consistently to
1m, to reduce the test package's overall runtime.
Ref:
https://onsi.github.io/gomega/#eventually
https://onsi.github.io/gomega/#consistently
Description of the change:
Motivation for the change:
Reviewer Checklist
/doc[FLAKE]are truly flaky[FLAKE]tag are no longer flaky