Remove the run-console-local Makefile target #2744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Signed-off-by: timflannagan <timflannagan@gmail.com>
timflannagan
force-pushed
the
makefile/remove-console-target
branch
from
db09456
to
e931a5e
Compare
|
Agreed, this can live downstream if we need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: timflannagan timflannagan@gmail.com
Description of the change:
Remove the largely unused run-console-local Makefile target which is responsible for running the openshift console in a docker container. This kind of target doesn't feel appropriate for an upstream environment and it reduces overall maintenance.
Motivation for the change:
Cleanup
Reviewer Checklist
/doc[FLAKE]are truly flaky[FLAKE]tag are no longer flaky