Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sec revert #2808

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Sec revert #2808

merged 3 commits into from
Jun 23, 2022

Conversation

perdasilva
Copy link
Collaborator

Motivation for the change:
Reverts security changes as they are breaking downstream
Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci
Copy link

openshift-ci bot commented Jun 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2022
@perdasilva
Revert "Unpack job security updates (operator-framework#2805)"
4d7c8de 
This reverts commit e568cde.

Signed-off-by: perdasilva <perdasilva@redhat.com>
@perdasilva
Revert "Update unpack job pod security (operator-framework#2793)"
183bbfe 
This reverts commit eedad28.

Signed-off-by: perdasilva <perdasilva@redhat.com>
@perdasilva
Revert "Update CatalogSource Pod security context (operator-framework…
36d5763 
…#2782)"

This reverts commit 99b51e7.

Signed-off-by: perdasilva <perdasilva@redhat.com>
@timflannagan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2022
@perdasilva perdasilva merged commit 0b7970c into operator-framework:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@benluddy benluddy Awaiting requested review from benluddy

Assignees

@timflannagan timflannagan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@perdasilva @timflannagan