Only update namespaces when OperatorGroup labels need to change. #2809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
benluddy
commented
Jul 1, 2022
| return nil | ||
| } | ||
|
|
||
| namespace = namespace.DeepCopy() |
There was a problem hiding this comment.
This should also fix informer cache corruption.
Even when the update request is a semantic no-op, it generates a little apiserver and etcd load. Also, other controllers are watching namespaces and will perform redundant work in response to the generated watch event and resourceVersion bump. Signed-off-by: Ben Luddy <bluddy@redhat.com>
benluddy
force-pushed
the
skip-redundant-namespace-updates
branch
from
2d1f5da
to
97a48fc
Compare
|
/assign @awgreene |
awgreene
reviewed
Jul 6, 2022
awgreene
reviewed
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even when the update request is a semantic no-op, it generates a
little apiserver and etcd load. Also, other controllers are watching
namespaces and will perform redundant work in response to the
generated watch event and resourceVersion bump.