improve CA and certificate generation #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently during an audit on a user's cluster, it was discovered that
OLM's certificate generation functionality has a few minor shortcomings.
1) The generated CA and server cert do not include a common name,
which causes some tooling to have trouble tracing the cert chain.
2) The generated CA and server cert include unnecessary key usages,
which means those certificates can be used for more than their
intended purposes.
This commit resolves the above issues by ensuring the certificates
include common names and by using the minimal key usages necessary.
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
timflannagan
reviewed
Aug 9, 2022
| @@ -120,12 +120,12 @@ func CreateSignedServingPair(notAfter time.Time, organization string, ca *KeyPai | |||
| certDetails := &x509.Certificate{ | |||
| SerialNumber: serial, | |||
| Subject: pkix.Name{ | |||
| CommonName: hosts[0], | |||
There was a problem hiding this comment.
Do we do any length checking for the hosts array length anywhere?
There was a problem hiding this comment.
Right now, it always has exactly two items:
<svcName>.<svcNamespace><svcName>.<svcNamespace>.svc
There was a problem hiding this comment.
Alright, works for me.
/lgtm
|
Just one quick question, but otherwise this lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change:
Recently during an audit on a user's cluster, it was discovered that
OLM's certificate generation functionality has a few minor shortcomings.
which causes some tooling to have trouble tracing the cert chain.
which means those certificates can be used for more than their
intended purposes.
Description of the change:
This commit resolves the above issues by ensuring the certificates
include common names and by using the minimal key usages necessary.
Testing remarks:
Thus far, I have only manually tested via
run-localand verified that:Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue