Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes doc error: namespace name must have changed #2839

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

bentito
Copy link
Contributor

@bentito bentito commented Aug 16, 2022

$ kubectl -n local get deployments
No resources found in local namespace.

$ kubectl -n olm get deployments
NAME READY UP-TO-DATE AVAILABLE AGE
catalog-operator 1/1 1 1 6m11s
olm-operator 1/1 1 1 10m
packageserver 1/1 1 1 10m

Description of the change:
Fixing an error in the install docs.

Motivation for the change:
Error was found

Architectural changes:
None

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • [ x] Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci
Copy link

openshift-ci bot commented Aug 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bentito, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2022
@timflannagan
Copy link
Contributor

@bentito Looks like you need to sign the DCO before this can merge.

$ kubectl -n local get deployments
No resources found in local namespace.

$ kubectl -n olm get deployments
NAME               READY   UP-TO-DATE   AVAILABLE   AGE
catalog-operator   1/1     1            1           6m11s
olm-operator       1/1     1            1           10m
packageserver      1/1     1            1           10m

Signed-off-by: Brett Tofel <btofel@redhat.com>
@timflannagan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2022
@openshift-merge-robot openshift-merge-robot merged commit 665c25b into operator-framework:master Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants