Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Allow E2E to skip multiple tests (#2892)" #2894

Merged

Conversation

awgreene
Copy link
Member

@awgreene awgreene commented Nov 12, 2022

This reverts commit 6cfd86c, which is
not necessary because the ginkgo run --skip flag supports regex.

@openshift-ci
Copy link

openshift-ci bot commented Nov 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2022
This reverts commit 6cfd86c, which is
not necessary because the ginkgo run --skip flag supports regex.

Signed-off-by: Alexander Greene <greene.al1991@gmail.com>
@dtfranz
Copy link
Contributor

dtfranz commented Nov 14, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2022
@openshift-merge-robot openshift-merge-robot merged commit 80b914d into operator-framework:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants