Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/containerd/containerd to 1.6.10 #2903

Merged

Conversation

cblecker
Copy link
Contributor

@cblecker cblecker commented Dec 2, 2022

Description of the change:
Bump github.com/containerd/containerd to 1.6.10 to remediate CVE-2022-31030
Details: GHSA-5ffw-gxpp-mxpf

Motivation for the change:
Remediate CVE

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Dec 2, 2022

Hi @cblecker. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Christoph Blecker <cblecker@redhat.com>
Signed-off-by: Christoph Blecker <cblecker@redhat.com>
@grokspawn
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 2, 2022
@cblecker
Copy link
Contributor Author

cblecker commented Dec 2, 2022

Looks like the unit test failure that is being reported also exists in the mainline branch: https://github.com/operator-framework/operator-lifecycle-manager/actions/runs/3584969022/jobs/6032331697#step:5:77

@exdx
Copy link
Member

exdx commented Dec 3, 2022

/retest
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2022
@cblecker cblecker mentioned this pull request Dec 4, 2022
11 tasks
@grokspawn
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2022
@openshift-merge-robot openshift-merge-robot merged commit afbb609 into operator-framework:master Dec 5, 2022
@cblecker cblecker deleted the bump-containerd branch December 5, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants