Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update e2e catalogSources to run in restricted mode #2909

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Update e2e catalogSources to run in restricted mode #2909

merged 1 commit into from
Dec 16, 2022

Conversation

awgreene
Copy link
Member

With the recent changes to default to legacy mode, some distributions of OLM are unable to run as the catalogSources are running in legacy mode in restricted namespaces.

This commit configures the catalogSource pods in the e2e suite to run in restricted mode.

Signed-off-by: Alexander Greene greene.al1991@gmail.com

@openshift-ci openshift-ci bot requested review from exdx and oceanc80 December 16, 2022 05:20
@openshift-ci
Copy link

openshift-ci bot commented Dec 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2022
@awgreene
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2022
@awgreene
Update e2e catalogSources to run in restricted mode
6324f5b 
With the recent changes to default to legacy mode, some distributions of
OLM are unable to run as the catalogSources are running in legacy mode
in restricted namespaces.

This commit configures the catalogSource pods in the e2e suite to run in
restricted mode.

Signed-off-by: Alexander Greene <greene.al1991@gmail.com>
joelanford
joelanford reviewed Dec 16, 2022
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2022
@awgreene
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2022
@openshift-merge-robot openshift-merge-robot merged commit d82537c into operator-framework:master Dec 16, 2022
@awgreene
Copy link
Member Author

/cherry-pick release-4.12

@openshift-cherrypick-robot
Copy link

@awgreene: cannot checkout release-4.12: error checking out release-4.12: exit status 1. output: error: pathspec 'release-4.12' did not match any file(s) known to git

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford left review comments

@exdx exdx Awaiting requested review from exdx

@oceanc80 oceanc80 Awaiting requested review from oceanc80

Assignees

@joelanford joelanford

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@awgreene @openshift-cherrypick-robot @joelanford @openshift-merge-robot