Removes error silencing from IsFailForwardEnabled #2957
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
IsFailForwardEnabled
is currently silincing errors fromList
method. This change makes it propogate errors to the caller.IsFailForwardEnabled
currently has a specifal case for situation where there are 0OperatorGroups
(len(ogs) == 0
) which no longer makes sense: oneOperatorGroups
is required. This now falls into more genericlen(ogs) != 1
condition.Main change is in
pkg/controller/registry/resolver/fail_forward.go
. Everything else is just updates required to fix tests: many of them were working without a fake operator group before.Motivation for the change:
Follow up from this conversation - #2952 (comment).
Architectural changes:
Change in how we handle zero
OperatorGroups
.Testing remarks:
Existing tests should cover the change.
Reviewer Checklist
/doc
[FLAKE]
are truly flaky and have an issue