Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switches from BundleLookupFailed defined in OLM to the one defined in the .../api package #2959

Merged

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Apr 25, 2023

Description of the change:

BundleLookupFailed is currently defined in the OLM codebase, but the latest release of the github.com/operator-framework/api package contains BundleLookupFailed definition (see the relevant PR).

This PR updates OLM to switch to the constant defined in github.com/operator-framework/api

Motivation for the change:

Cleanup of the old TODO.

Architectural changes:

Refactoring

Testing remarks:

Existing tests should cover changes.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 25, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@m1kola m1kola force-pushed the BundleLookupFailed-todo-cleanup branch from c48e609 to 86aa8e4 Compare April 26, 2023 15:18
@m1kola m1kola marked this pull request as ready for review April 26, 2023 15:33
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 26, 2023
Copy link
Contributor

@ankitathomas ankitathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2023
Copy link
Collaborator

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - nice! thanks for not letting this drop!!

@openshift-ci
Copy link

openshift-ci bot commented May 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas, m1kola, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2023
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@perdasilva perdasilva force-pushed the BundleLookupFailed-todo-cleanup branch from 86aa8e4 to 8ca28d8 Compare May 22, 2023 11:25
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 22, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 22, 2023

New changes are detected. LGTM label has been removed.

@perdasilva perdasilva merged commit 3ee218b into operator-framework:master May 22, 2023
@m1kola m1kola deleted the BundleLookupFailed-todo-cleanup branch May 22, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants